[PR #417] [MERGED] #416 Fix searches expecing all items to be non-nullable #428

New issue

Closed

opened 2026-02-27 19:18:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:18:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/417
Author: @EddieTheCubeHead
Created: 12/27/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @EddieTheCubeHead

Base: master ← Head: 416-spotify-api-update-broke-some-routes

📝 Commits (3)

a545869 #416 Fix searches expecing all items to be non-nullable
d8441a1 #416 Update ruff and run autoformat
f369a80 #416 Run ruff check with fix, manually fix unsafe cases

📊 Changes

54 files changed (+263 additions, -190 deletions)

View changed files

📝 server/pyproject.toml (+0 -2)
📝 server/src/alembic/env.py (+2 -1)
📝 server/src/alembic/versions/149e2197ecff_add_data_required_for_login_and_auth_.py (+3 -1)
📝 server/src/alembic/versions/1dc141893e67_add_support_for_promoting_tracks.py (+3 -1)
📝 server/src/alembic/versions/25c34e5bf930_data_changes_required_for_pool_.py (+3 -1)
📝 server/src/alembic/versions/27048d682757_make_user_icon_url_nullable.py (+3 -1)
📝 server/src/alembic/versions/3b8805c4d7db_fixing_incorrect_foreign_keys.py (+3 -1)
📝 server/src/alembic/versions/4fc5f9bc5558_double_avatar_url_length.py (+3 -1)
📝 server/src/alembic/versions/62ec829ee3f3_caching_current_song_playback_data_in_.py (+3 -1)
📝 server/src/alembic/versions/6b917dddd71e_add_model_for_pool_members.py (+3 -1)
📝 server/src/alembic/versions/70e02357c5ff_big_changes_for_support_for_pool_.py (+3 -1)
📝 server/src/alembic/versions/7851701cd257_add_playback_status_entity.py (+3 -1)
📝 server/src/alembic/versions/a864a5084871_new_field_for_user_session_for_storing_.py (+3 -1)
📝 server/src/alembic/versions/aeb0c7f142d6_increase_field_sizes_for_pool_members.py (+3 -1)
📝 server/src/alembic/versions/af9978211950_add_user_table.py (+3 -1)
📝 server/src/api/application.py (+1 -1)
📝 server/src/api/auth/dependencies.py (+2 -2)
📝 server/src/api/auth/tasks.py (+1 -2)
📝 server/src/api/common/dependencies.py (+6 -6)
📝 server/src/api/common/helpers.py (+1 -1)

...and 34 more files

📄 Description

The search routes were only relevant changes found. They now send null objects up to limit given even if no results exist, meaning there were errors in result parsing expecting lists to have no nulls.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/417 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 12/27/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Base:** `master` ← **Head:** `416-spotify-api-update-broke-some-routes` --- ### 📝 Commits (3) - [`a545869`](https://github.com/EddieTheCubeHead/Stagnum/commit/a54586987da4cc76be0313e0508345101e887758) #416 Fix searches expecing all items to be non-nullable - [`d8441a1`](https://github.com/EddieTheCubeHead/Stagnum/commit/d8441a15090816e2c87ad6e08b8f7204c483af46) #416 Update ruff and run autoformat - [`f369a80`](https://github.com/EddieTheCubeHead/Stagnum/commit/f369a80ebbc1d91d23549ceb40d754991643358e) #416 Run ruff check with fix, manually fix unsafe cases ### 📊 Changes **54 files changed** (+263 additions, -190 deletions) <details> <summary>View changed files</summary> 📝 `server/pyproject.toml` (+0 -2) 📝 `server/src/alembic/env.py` (+2 -1) 📝 `server/src/alembic/versions/149e2197ecff_add_data_required_for_login_and_auth_.py` (+3 -1) 📝 `server/src/alembic/versions/1dc141893e67_add_support_for_promoting_tracks.py` (+3 -1) 📝 `server/src/alembic/versions/25c34e5bf930_data_changes_required_for_pool_.py` (+3 -1) 📝 `server/src/alembic/versions/27048d682757_make_user_icon_url_nullable.py` (+3 -1) 📝 `server/src/alembic/versions/3b8805c4d7db_fixing_incorrect_foreign_keys.py` (+3 -1) 📝 `server/src/alembic/versions/4fc5f9bc5558_double_avatar_url_length.py` (+3 -1) 📝 `server/src/alembic/versions/62ec829ee3f3_caching_current_song_playback_data_in_.py` (+3 -1) 📝 `server/src/alembic/versions/6b917dddd71e_add_model_for_pool_members.py` (+3 -1) 📝 `server/src/alembic/versions/70e02357c5ff_big_changes_for_support_for_pool_.py` (+3 -1) 📝 `server/src/alembic/versions/7851701cd257_add_playback_status_entity.py` (+3 -1) 📝 `server/src/alembic/versions/a864a5084871_new_field_for_user_session_for_storing_.py` (+3 -1) 📝 `server/src/alembic/versions/aeb0c7f142d6_increase_field_sizes_for_pool_members.py` (+3 -1) 📝 `server/src/alembic/versions/af9978211950_add_user_table.py` (+3 -1) 📝 `server/src/api/application.py` (+1 -1) 📝 `server/src/api/auth/dependencies.py` (+2 -2) 📝 `server/src/api/auth/tasks.py` (+1 -2) 📝 `server/src/api/common/dependencies.py` (+6 -6) 📝 `server/src/api/common/helpers.py` (+1 -1) _...and 34 more files_ </details> ### 📄 Description The search routes were only relevant changes found. They now send null objects up to limit given even if no results exist, meaning there were errors in result parsing expecting lists to have no nulls. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>