mirror of
https://github.com/EddieTheCubeHead/Stagnum.git
synced 2026-04-26 06:05:49 +03:00
[PR #301] [MERGED] 293 terraform workflow improvement #371
Labels
No labels
bug
bug
client
design
documentation
feature
feature
infrastructure
pull-request
ready for development
server
server
spike
technical work
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Stagnum#371
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/301
Author: @ekosfin
Created: 4/22/2024
Status: ✅ Merged
Merged: 4/22/2024
Merged by: @ekosfin
Base:
master← Head:293-terraform-workflow-improvement📝 Commits (5)
adc14cfModified workflow to output plan to pr comment84344a2Added terraform apply step9777d57removed checkout ref as it interferes with forked pull requests85a747cAdded path to upload183b545main to master📊 Changes
1 file changed (+163 additions, -74 deletions)
View changed files
📝
.github/workflows/terraform.yml(+163 -74)📄 Description
Did a bit of an rework on the terraform workflow. Now it does not commit to the branch, but fails the workflow if the formatting is wrong. Also, it should now comment on the pull request with the plan for review.
Next steps would be to set up OICD and two IAM roles that correspond with plan and apply permissions.
Related: https://github.com/EddieTheCubeHead/Stagnum/issues/293
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.