[PR #252] [MERGED] 251 getting and sharing a pool if none exists threw 500 instead of 404 #347

New issue

Closed

opened 2026-02-27 19:17:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/252
Author: @EddieTheCubeHead
Created: 4/15/2024
Status: ✅ Merged
Merged: 4/15/2024
Merged by: @EddieTheCubeHead

Base: master ← Head: 251-fetching-pool-when-none-exists-causes-an-internal-server-error

📝 Commits (2)

bbc9c46 251 getting and sharing a pool if none exists threw 500 instead of 404
6af5340 Merge branch 'master' into 251-fetching-pool-when-none-exists-causes-an-internal-server-error

📊 Changes

3 files changed (+19 additions, -0 deletions)

View changed files

📝 server/src/api/pool/dependencies.py (+4 -0)
📝 server/test/pool_features/get_pool_features.py (+7 -0)
📝 server/test/pool_features/shared_pool_features.py (+8 -0)

📄 Description

Added tests and fixed functionality

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/252 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 4/15/2024 **Status:** ✅ Merged **Merged:** 4/15/2024 **Merged by:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Base:** `master` ← **Head:** `251-fetching-pool-when-none-exists-causes-an-internal-server-error` --- ### 📝 Commits (2) - [`bbc9c46`](https://github.com/EddieTheCubeHead/Stagnum/commit/bbc9c46aa3d299049d9fce285ab0d2b2c385b573) 251 getting and sharing a pool if none exists threw 500 instead of 404 - [`6af5340`](https://github.com/EddieTheCubeHead/Stagnum/commit/6af534029cc5fa14be951130a4aebd7dfabe26a5) Merge branch 'master' into 251-fetching-pool-when-none-exists-causes-an-internal-server-error ### 📊 Changes **3 files changed** (+19 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/src/api/pool/dependencies.py` (+4 -0) 📝 `server/test/pool_features/get_pool_features.py` (+7 -0) 📝 `server/test/pool_features/shared_pool_features.py` (+8 -0) </details> ### 📄 Description Added tests and fixed functionality --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>