[PR #201] [MERGED] 200 rename authorization header to adhere to industry standards #317

New issue

Closed

opened 2026-02-27 19:17:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/201
Author: @EddieTheCubeHead
Created: 4/6/2024
Status: ✅ Merged
Merged: 4/7/2024
Merged by: @EddieTheCubeHead

Base: master ← Head: 200-rename-authorization-header-to-adhere-to-industry-standards

📝 Commits (3)

5a655ff 200 Change header field name from "token" to "Authorization" in client code
5cb77ef 200 Change "token" to "Authorization" in core headers and update tests
b91e739 Merge branch 'master' into 200-rename-authorization-header-to-adhere-to-industry-standards

📊 Changes

18 files changed (+44 additions, -38 deletions)

View changed files

📝 client/components/buttons/iconButtons/addToPoolButton.tsx (+1 -1)
📝 client/components/buttons/iconButtons/deleteButton.tsx (+2 -2)
📝 client/components/buttons/iconButtons/showMoreIconButton.tsx (+1 -1)
📝 client/components/buttons/skipButton.tsx (+1 -1)
📝 client/components/layout/poolManager.tsx (+1 -1)
📝 client/components/layout/search.tsx (+2 -2)
📝 server/src/api/common/dependencies.py (+8 -4)
📝 server/test/conftest.py (+1 -1)
📝 server/test/pool_features/conftest.py (+1 -1)
📝 server/test/pool_features/create_pool_features.py (+5 -5)
📝 server/test/pool_features/playback_features.py (+5 -5)
📝 server/test/pool_features/playback_websocket_features.py (+2 -2)
📝 server/test/pool_features/pool_websocket_features.py (+5 -3)
📝 server/test/search_features/album_search_features.py (+2 -2)
📝 server/test/search_features/artist_search_features.py (+2 -2)
📝 server/test/search_features/general_search_features.py (+1 -1)
📝 server/test/search_features/playlist_search_features.py (+2 -2)
📝 server/test/search_features/track_search_features.py (+2 -2)

📄 Description

While this is not strictly required for it, this creates nice consistency with the upcoming refresh token implementation so I just went ahead and did this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/201 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 4/6/2024 **Status:** ✅ Merged **Merged:** 4/7/2024 **Merged by:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Base:** `master` ← **Head:** `200-rename-authorization-header-to-adhere-to-industry-standards` --- ### 📝 Commits (3) - [`5a655ff`](https://github.com/EddieTheCubeHead/Stagnum/commit/5a655ff4dd5ea72b0041f32215ecde6a41aea714) 200 Change header field name from "token" to "Authorization" in client code - [`5cb77ef`](https://github.com/EddieTheCubeHead/Stagnum/commit/5cb77ef8af4a5ff4ce9d05837981193432c47c37) 200 Change "token" to "Authorization" in core headers and update tests - [`b91e739`](https://github.com/EddieTheCubeHead/Stagnum/commit/b91e73916ae16090f880d8d9529f4b01ba9e69eb) Merge branch 'master' into 200-rename-authorization-header-to-adhere-to-industry-standards ### 📊 Changes **18 files changed** (+44 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `client/components/buttons/iconButtons/addToPoolButton.tsx` (+1 -1) 📝 `client/components/buttons/iconButtons/deleteButton.tsx` (+2 -2) 📝 `client/components/buttons/iconButtons/showMoreIconButton.tsx` (+1 -1) 📝 `client/components/buttons/skipButton.tsx` (+1 -1) 📝 `client/components/layout/poolManager.tsx` (+1 -1) 📝 `client/components/layout/search.tsx` (+2 -2) 📝 `server/src/api/common/dependencies.py` (+8 -4) 📝 `server/test/conftest.py` (+1 -1) 📝 `server/test/pool_features/conftest.py` (+1 -1) 📝 `server/test/pool_features/create_pool_features.py` (+5 -5) 📝 `server/test/pool_features/playback_features.py` (+5 -5) 📝 `server/test/pool_features/playback_websocket_features.py` (+2 -2) 📝 `server/test/pool_features/pool_websocket_features.py` (+5 -3) 📝 `server/test/search_features/album_search_features.py` (+2 -2) 📝 `server/test/search_features/artist_search_features.py` (+2 -2) 📝 `server/test/search_features/general_search_features.py` (+1 -1) 📝 `server/test/search_features/playlist_search_features.py` (+2 -2) 📝 `server/test/search_features/track_search_features.py` (+2 -2) </details> ### 📄 Description While this is not strictly required for it, this creates nice consistency with the upcoming refresh token implementation so I just went ahead and did this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>