[PR #196] [MERGED] 195 Create a new pool corrupts data in backend #316

New issue

Closed

opened 2026-02-27 19:17:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/196
Author: @EddieTheCubeHead
Created: 4/6/2024
Status: ✅ Merged
Merged: 4/7/2024
Merged by: @EddieTheCubeHead

Base: master ← Head: 195-creating-a-new-pool-corrupts-data-in-backend

📝 Commits (1)

5f38158 195 Create a new pool corrupts data in backend

📊 Changes

2 files changed (+5 additions, -4 deletions)

View changed files

📝 server/src/api/pool/dependencies.py (+3 -2)
📝 server/src/database/entities.py (+2 -2)

📄 Description

FK relationship was marking a property as null and causing core to think we are creating user's first pool. Changed to read a property that is not a relationship. Fixed small typing errors
Fixed playback starting not using the new randomization algorithm

No new test for this as SQLite doesn't respect FK functionality and thus this cannot be reproduced in our test suite as it stands

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/196 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 4/6/2024 **Status:** ✅ Merged **Merged:** 4/7/2024 **Merged by:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Base:** `master` ← **Head:** `195-creating-a-new-pool-corrupts-data-in-backend` --- ### 📝 Commits (1) - [`5f38158`](https://github.com/EddieTheCubeHead/Stagnum/commit/5f3815877d65252492824833354e92ceae5cf83b) 195 Create a new pool corrupts data in backend ### 📊 Changes **2 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/src/api/pool/dependencies.py` (+3 -2) 📝 `server/src/database/entities.py` (+2 -2) </details> ### 📄 Description FK relationship was marking a property as null and causing core to think we are creating user's first pool. Changed to read a property that is not a relationship. Fixed small typing errors Fixed playback starting not using the new randomization algorithm No new test for this as SQLite doesn't respect FK functionality and thus this cannot be reproduced in our test suite as it stands --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>