[PR #194] [MERGED] 189 subtask go through backend routes add handling for errors by raising httpexception #315

New issue

Closed

opened 2026-02-27 19:17:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/194
Author: @EddieTheCubeHead
Created: 4/6/2024
Status: ✅ Merged
Merged: 4/7/2024
Merged by: @EddieTheCubeHead

Base: master ← Head: 189-subtask-go-through-backend-routes-add-handling-for-errors-by-raising-httpexception

📝 Commits (10+)

4e48ae4 189 better internal server error handling
e1ae8c7 189 Raise exception if spotify client id or secret are missing in login callback
421e554 Merge branch '164-subtask-create-websocket-for-updating-currently-playing-song-information' into 189-subtask-go-through-backend-routes-add-handling-for-errors-by-raising-httpexception
2e61f47 189 Update spotify client dependency to more reliably and cleanly bubble exceptions from spotify API through to client
96b6d86 189 Ensure search routes propagate spotify errors
fb66d46 189 Better fixture support for testing propagating spotify errors
99d3ac0 189 Ensure adding pool content propagates spotify errors
5e365ae 189 Exceptions for invalid pool member deletions
d4072c2 189 Update example.env
39648c8 Merge branch 'master' into 189-subtask-go-through-backend-routes-add-handling-for-errors-by-raising-httpexception

📊 Changes

17 files changed (+231 additions, -72 deletions)

View changed files

📝 example.env (+3 -0)
📝 server/README.md (+2 -0)
📝 server/src/api/auth/dependencies.py (+26 -21)
📝 server/src/api/common/dependencies.py (+20 -9)
📝 server/src/api/common/helpers.py (+11 -0)
📝 server/src/api/pool/dependencies.py (+22 -19)
📝 server/src/api/pool/routes.py (+1 -2)
📝 server/src/api/search/dependencies.py (+3 -3)
📝 server/test/auth_features/auth_login_callback_features.py (+38 -8)
📝 server/test/auth_features/auth_login_features.py (+10 -1)
📝 server/test/conftest.py (+29 -1)
📝 server/test/pool_features/add_content_features.py (+13 -0)
📝 server/test/pool_features/create_pool_features.py (+13 -0)
📝 server/test/pool_features/delete_content_features.py (+22 -4)
📝 server/test/pool_features/playback_websocket_features.py (+3 -4)
📝 server/test/search_features/album_search_features.py (+1 -0)
📝 server/test/search_features/general_search_features.py (+14 -0)

📄 Description

All spotify errors now propagate to frontend with code 502
Missing critical env variables now throw internal server error
Added environment variable 'ENVIRONMENT', (default: 'production')
- Internal server errors now display exact reason for error only in non-production environment
Trying to delete a non-existent pool member now returns error with description
Trying to delete another user's pool member now returns error with description

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/194 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 4/6/2024 **Status:** ✅ Merged **Merged:** 4/7/2024 **Merged by:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Base:** `master` ← **Head:** `189-subtask-go-through-backend-routes-add-handling-for-errors-by-raising-httpexception` --- ### 📝 Commits (10+) - [`4e48ae4`](https://github.com/EddieTheCubeHead/Stagnum/commit/4e48ae43a0d1ddb89f7dade9dc73eacf161f1d94) 189 better internal server error handling - [`e1ae8c7`](https://github.com/EddieTheCubeHead/Stagnum/commit/e1ae8c7fb21e294438c77d04c74951d2ac52bf2b) 189 Raise exception if spotify client id or secret are missing in login callback - [`421e554`](https://github.com/EddieTheCubeHead/Stagnum/commit/421e55412f8e6ae671b483ed2b7a0322e11b2add) Merge branch '164-subtask-create-websocket-for-updating-currently-playing-song-information' into 189-subtask-go-through-backend-routes-add-handling-for-errors-by-raising-httpexception - [`2e61f47`](https://github.com/EddieTheCubeHead/Stagnum/commit/2e61f47ae8156551272a845f64793adf1855c834) 189 Update spotify client dependency to more reliably and cleanly bubble exceptions from spotify API through to client - [`96b6d86`](https://github.com/EddieTheCubeHead/Stagnum/commit/96b6d86d9a707ad3836086b8c5e887d0ef16b1b9) 189 Ensure search routes propagate spotify errors - [`fb66d46`](https://github.com/EddieTheCubeHead/Stagnum/commit/fb66d46b4c602b4ce5322520d355c61e00832ef5) 189 Better fixture support for testing propagating spotify errors - [`99d3ac0`](https://github.com/EddieTheCubeHead/Stagnum/commit/99d3ac00ea47434637b1805445093a34315ced87) 189 Ensure adding pool content propagates spotify errors - [`5e365ae`](https://github.com/EddieTheCubeHead/Stagnum/commit/5e365ae15faaf7becf670c1c37b28ea0940adbea) 189 Exceptions for invalid pool member deletions - [`d4072c2`](https://github.com/EddieTheCubeHead/Stagnum/commit/d4072c27ec1f85214b00af4aef2efcaf27329a28) 189 Update example.env - [`39648c8`](https://github.com/EddieTheCubeHead/Stagnum/commit/39648c8b94f6d22df522b478c282516eb613dd01) Merge branch 'master' into 189-subtask-go-through-backend-routes-add-handling-for-errors-by-raising-httpexception ### 📊 Changes **17 files changed** (+231 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `example.env` (+3 -0) 📝 `server/README.md` (+2 -0) 📝 `server/src/api/auth/dependencies.py` (+26 -21) 📝 `server/src/api/common/dependencies.py` (+20 -9) 📝 `server/src/api/common/helpers.py` (+11 -0) 📝 `server/src/api/pool/dependencies.py` (+22 -19) 📝 `server/src/api/pool/routes.py` (+1 -2) 📝 `server/src/api/search/dependencies.py` (+3 -3) 📝 `server/test/auth_features/auth_login_callback_features.py` (+38 -8) 📝 `server/test/auth_features/auth_login_features.py` (+10 -1) 📝 `server/test/conftest.py` (+29 -1) 📝 `server/test/pool_features/add_content_features.py` (+13 -0) 📝 `server/test/pool_features/create_pool_features.py` (+13 -0) 📝 `server/test/pool_features/delete_content_features.py` (+22 -4) 📝 `server/test/pool_features/playback_websocket_features.py` (+3 -4) 📝 `server/test/search_features/album_search_features.py` (+1 -0) 📝 `server/test/search_features/general_search_features.py` (+14 -0) </details> ### 📄 Description - All spotify errors now propagate to frontend with code 502 - Missing critical env variables now throw internal server error - Added environment variable 'ENVIRONMENT', (default: 'production') - Internal server errors now display exact reason for error only in non-production environment - Trying to delete a non-existent pool member now returns error with description - Trying to delete another user's pool member now returns error with description --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>