[PR #117] [MERGED] 111 fix pool playback #280

New issue

Closed

opened 2026-02-27 19:17:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/117
Author: @EddieTheCubeHead
Created: 3/5/2024
Status: ✅ Merged
Merged: 3/6/2024
Merged by: @KeManen

Base: master ← Head: 111-fix-pool-playback

📝 Commits (2)

09292f5 111 fix pool playback
f85a870 111 Added a test for new functionality

📊 Changes

5 files changed (+94 additions, -21 deletions)

View changed files

➕ server/src/alembic/versions/3b8805c4d7db_fixing_incorrect_foreign_keys.py (+41 -0)
📝 server/src/api/common/dependencies.py (+9 -9)
📝 server/src/api/pool/dependencies.py (+2 -2)
📝 server/src/database/entities.py (+6 -10)
📝 server/test/pool_features/playback_features.py (+36 -0)

📄 Description

Simpler fix than predicted:
Some confusion with SQLAlchemy fk constraints, fixed
Forgot to set created playback as active if there was existing playback

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/117 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 3/5/2024 **Status:** ✅ Merged **Merged:** 3/6/2024 **Merged by:** [@KeManen](https://github.com/KeManen) **Base:** `master` ← **Head:** `111-fix-pool-playback` --- ### 📝 Commits (2) - [`09292f5`](https://github.com/EddieTheCubeHead/Stagnum/commit/09292f5fc77ac7d0ac4c8d2a9656f8bb63d9a114) 111 fix pool playback - [`f85a870`](https://github.com/EddieTheCubeHead/Stagnum/commit/f85a87099e509a394db32ae3deb03100c06a009e) 111 Added a test for new functionality ### 📊 Changes **5 files changed** (+94 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `server/src/alembic/versions/3b8805c4d7db_fixing_incorrect_foreign_keys.py` (+41 -0) 📝 `server/src/api/common/dependencies.py` (+9 -9) 📝 `server/src/api/pool/dependencies.py` (+2 -2) 📝 `server/src/database/entities.py` (+6 -10) 📝 `server/test/pool_features/playback_features.py` (+36 -0) </details> ### 📄 Description Simpler fix than predicted: Some confusion with SQLAlchemy fk constraints, fixed Forgot to set created playback as active if there was existing playback --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>