[PR #119] [MERGED] 97 playlist handling in pool creation is broken #277

New issue

Closed

opened 2026-02-27 19:17:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:17:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/119
Author: @EddieTheCubeHead
Created: 3/9/2024
Status: ✅ Merged
Merged: 3/9/2024
Merged by: @KeManen

Base: master ← Head: 97-playlist-handling-in-pool-creation-is-broken

📝 Commits (4)

b59d203 97 Fix code expecting wrong playlist data format on fetch
95b0189 97 Enable fetching playlists larger than 100 songs
f0dc76c Merge branch 'master' into 97-playlist-handling-in-pool-creation-is-broken
a54711e 97 Remove WIP mark

📊 Changes

9 files changed (+202 additions, -57 deletions)

View changed files

📝 server/src/api/auth/dependencies.py (+2 -2)
📝 server/src/api/common/dependencies.py (+14 -14)
📝 server/src/api/pool/dependencies.py (+16 -3)
📝 server/test/pool_features/add_content_features.py (+4 -5)
📝 server/test/pool_features/conftest.py (+96 -0)
📝 server/test/pool_features/create_pool_features.py (+36 -14)
📝 server/test/pool_features/delete_content_features.py (+8 -9)
📝 server/test/pool_features/get_pool_features.py (+2 -2)
📝 server/test/pool_features/playback_features.py (+24 -8)

📄 Description

Two problems fixed:

We were handling playlist data incorrectly when fetching from spotify playlist GET endpoint instead of general search. The endpoint returns a deeper data structure with extra metadata for each playlist track inserted in the middle. Modified relevant tests to accomodate this and fixed handling.
Spotify only sends the first 100 songs of a playlist on fetch. Made a test for fetching all iteratively and implemented functionality.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/119 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 3/9/2024 **Status:** ✅ Merged **Merged:** 3/9/2024 **Merged by:** [@KeManen](https://github.com/KeManen) **Base:** `master` ← **Head:** `97-playlist-handling-in-pool-creation-is-broken` --- ### 📝 Commits (4) - [`b59d203`](https://github.com/EddieTheCubeHead/Stagnum/commit/b59d203d5464126a1e4496d7a6374677495ff310) 97 Fix code expecting wrong playlist data format on fetch - [`95b0189`](https://github.com/EddieTheCubeHead/Stagnum/commit/95b0189fa388b5174c0a12027a81f7e10dde6fdc) 97 Enable fetching playlists larger than 100 songs - [`f0dc76c`](https://github.com/EddieTheCubeHead/Stagnum/commit/f0dc76cb855c03d6ed7930553054c6e781830e91) Merge branch 'master' into 97-playlist-handling-in-pool-creation-is-broken - [`a54711e`](https://github.com/EddieTheCubeHead/Stagnum/commit/a54711e3a76b4e06c9edd1b90659fd36aa2b931f) 97 Remove WIP mark ### 📊 Changes **9 files changed** (+202 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `server/src/api/auth/dependencies.py` (+2 -2) 📝 `server/src/api/common/dependencies.py` (+14 -14) 📝 `server/src/api/pool/dependencies.py` (+16 -3) 📝 `server/test/pool_features/add_content_features.py` (+4 -5) 📝 `server/test/pool_features/conftest.py` (+96 -0) 📝 `server/test/pool_features/create_pool_features.py` (+36 -14) 📝 `server/test/pool_features/delete_content_features.py` (+8 -9) 📝 `server/test/pool_features/get_pool_features.py` (+2 -2) 📝 `server/test/pool_features/playback_features.py` (+24 -8) </details> ### 📄 Description Two problems fixed: 1. We were handling playlist data incorrectly when fetching from spotify playlist GET endpoint instead of general search. The endpoint returns a deeper data structure with extra metadata for each playlist track inserted in the middle. Modified relevant tests to accomodate this and fixed handling. 2. Spotify only sends the first 100 songs of a playlist on fetch. Made a test for fetching all iteratively and implemented functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>