[PR #61] [MERGED] 60 auth flow in core is not working correctly #259

Closed
opened 2026-02-27 19:17:29 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/EddieTheCubeHead/Stagnum/pull/61
Author: @EddieTheCubeHead
Created: 2/8/2024
Status: Merged
Merged: 2/8/2024
Merged by: @EddieTheCubeHead

Base: masterHead: 60-auth-flow-in-backend-not-working-correctly


📝 Commits (1)

📊 Changes

7 files changed (+26 additions, -27 deletions)

View changed files

📝 server/src/api/auth/models.py (+1 -1)
📝 server/src/api/auth/routes.py (+5 -5)
📝 server/src/api/common/dependencies.py (+1 -2)
📝 server/test/auth_features/auth_login_callback_features.py (+4 -4)
📝 server/test/auth_features/auth_login_features.py (+12 -12)
📝 server/test/auth_features/cleanup_state_strings_features.py (+2 -2)
📝 server/test/auth_features/conftest.py (+1 -1)

📄 Description

Changed "url" to "uri" everywhere but the database. Need to be a bit more careful with that so creating a separate ticket (+ it's just a semantic thing, not affecting functionality)

Fixed storing tokens in instance state instead of class state in token holder.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/EddieTheCubeHead/Stagnum/pull/61 **Author:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Created:** 2/8/2024 **Status:** ✅ Merged **Merged:** 2/8/2024 **Merged by:** [@EddieTheCubeHead](https://github.com/EddieTheCubeHead) **Base:** `master` ← **Head:** `60-auth-flow-in-backend-not-working-correctly` --- ### 📝 Commits (1) - [`66ede6e`](https://github.com/EddieTheCubeHead/Stagnum/commit/66ede6edf11ad16190957578c3825283c344703a) Add fixes ### 📊 Changes **7 files changed** (+26 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `server/src/api/auth/models.py` (+1 -1) 📝 `server/src/api/auth/routes.py` (+5 -5) 📝 `server/src/api/common/dependencies.py` (+1 -2) 📝 `server/test/auth_features/auth_login_callback_features.py` (+4 -4) 📝 `server/test/auth_features/auth_login_features.py` (+12 -12) 📝 `server/test/auth_features/cleanup_state_strings_features.py` (+2 -2) 📝 `server/test/auth_features/conftest.py` (+1 -1) </details> ### 📄 Description Changed "url" to "uri" everywhere but the database. Need to be a bit more careful with that so creating a separate ticket (+ it's just a semantic thing, not affecting functionality) Fixed storing tokens in instance state instead of class state in token holder. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 19:17:29 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Stagnum#259
No description provided.