[PR #248] [CLOSED] correctly implement whitespace trimming in sanitizePath #535

New issue

Closed

opened 2026-02-27 19:04:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:04:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/afkarxyz/SpotiFLAC/pull/248
Author: @talhoid
Created: 1/8/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

9cecafb correctly implement whitespace trimming in sanitizePath
de9a966 Merge branch 'afkarxyz:main' into main

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 frontend/src/lib/utils.ts (+1 -1)

📄 Description

This fixes a regression introduced by #215.

#215 did not successfully trim the whitespace. It assigns a new variable with a trimmed version of the string, but it never uses it for further sanitization. This also causes an error during compilation as the variable is unused:

    > tsc -b && vite build

    src/lib/utils.ts(12,7): error TS6133: 'sanitized' is declared but its value is never read.
     ELIFECYCLE  Command failed with exit code 2.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/afkarxyz/SpotiFLAC/pull/248 **Author:** [@talhoid](https://github.com/talhoid) **Created:** 1/8/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`9cecafb`](https://github.com/afkarxyz/SpotiFLAC/commit/9cecafb44efbcfb19272a021db44a1a526fa3c6e) correctly implement whitespace trimming in sanitizePath - [`de9a966`](https://github.com/afkarxyz/SpotiFLAC/commit/de9a96624197d4b2c4c96d8a74385c3bdfbe6b72) Merge branch 'afkarxyz:main' into main ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/lib/utils.ts` (+1 -1) </details> ### 📄 Description This fixes a regression introduced by #215. #215 did not successfully trim the whitespace. It assigns a new variable with a trimmed version of the string, but it never uses it for further sanitization. This also causes an error during compilation as the variable is unused: ``` > tsc -b && vite build src/lib/utils.ts(12,7): error TS6133: 'sanitized' is declared but its value is never read. ELIFECYCLE Command failed with exit code 2. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>