mirror of
https://github.com/afkarxyz/SpotiFLAC.git
synced 2026-04-26 07:35:52 +03:00
[GH-ISSUE #36] UI Freezes #28
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SpotiFLAC#28
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sakgoyal on GitHub (Jul 25, 2025).
Original GitHub issue: https://github.com/afkarxyz/SpotiFLAC/issues/36
I think the threading is broken. When I run this, I get 1 core stuck at 100% and the UI completely freezes and windows says it's not responding. but it is still running because the download folder size is going up.
Do you know what is causing the issue?
@sakgoyal commented on GitHub (Jul 25, 2025):
This is pinning this core to 100%
@afkarxyz commented on GitHub (Jul 25, 2025):
I have added the update check interval to 60 seconds, perhaps this can reduce CPU load. Please wait for the next update.
@sakgoyal commented on GitHub (Jul 25, 2025):
I fixed it myself. remove the stream=True from the request. just do a normal download and remove the chunk size from the iter_content. it made the download faster and no more freezes. CPU is now only ~5% without any issues.
the files are only ~15-30MB in size so streaming/chunking was completely unnecessary
@afkarxyz commented on GitHub (Jul 25, 2025):
I am using
stream=Truefor real-time progress tracking during download; I will consider it because you are the only one who opened the issue and you have already fixed it yourself.@sakgoyal commented on GitHub (Jul 25, 2025):
on any relatively good internet, downloading 20MB should be near instant. I don't see why you need to stream, and then chunk 8kb instead of just writing it at once.
I tested this with streaming but changed the chunking to 2MB instead of 8KB and it was also not causing issues. it had higher CPU usage (~10%). but it's much better than the 8KB setting.
Either remove streaming entirely (and lose a tiny amount of progress information), or increase chunking to 2MB. even 1MB should be better.
nobody is using internet that is slower than 1mbps
@afkarxyz commented on GitHub (Jul 26, 2025):
Fixed!