[PR #5] [CLOSED] Broken PR, please ignore #4

Closed
opened 2026-02-28 14:17:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AmarnathCJD/Spot-DL/pull/5
Author: @ghost
Created: 1/12/2026
Status: Closed

Base: kHead: k


📝 Commits (10+)

📊 Changes

65 files changed (+4608 additions, -22788 deletions)

View changed files

.cache (+1 -0)
📝 .gitignore (+5 -1)
📝 README.md (+48 -6)
album_utils.py (+89 -0)
artist_utils.py (+48 -0)
audio_utils.py (+26 -0)
auth.py (+20 -0)
config.toml (+12 -0)
📝 decrypt.py (+62 -54)
filesystem_utils.py (+13 -0)
libspot/__init__.py (+34 -0)
libspot/audio/__init__.py (+912 -0)
libspot/audio/decoders.py (+122 -0)
libspot/audio/decrypt.py (+45 -0)
libspot/audio/format.py (+37 -0)
libspot/audio/storage.py (+139 -0)
libspot/cache.py (+18 -0)
📝 libspot/core.py (+1054 -598)
📝 libspot/crypto.py (+10 -5)
libspot/dealer.py (+11 -0)

...and 45 more files

📄 Description

Changes

  • New arguments:

    • Added arguments for:
      • --album download a specific album, can be combined with --artist to refine the search
      • --artist download all albums by an artist
      • --url download by Spotify album/artist URL
      • --audio-format choose between ogg/mp3
  • Names, urls, directories:

    • URLs for albums, artists, and tracks are parsed and handled
    • Uses Spotipy to resolve names from IDs
    • Album directories are structured appropriately as <artist>/<album>/...
  • Config file:

    • config.toml was added for:
      • spotify_api_id developer API key, required for searches
      • spotify_api_secret developer API secret, required for searches
      • library_path export path for downloaded albums
      • track_sleep time to sleep between tracks
      • album_sleep time to sleep between albums
  • Original code:

    • Existing API endpoints and usage are preserved
    • CLI and API can be used interchangeably
    • Starts the same with no CLI args:
      python main.py

Usage

  • CLI Examples:
    • Download an album:
      python main.py --album "Album Name" --artist "Artist Name"
    • Download all albums by an artist:
      python main.py --artist "Artist Name"
    • Download by Spotify URL:
      python main.py --url https://open.spotify.com/album/...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AmarnathCJD/Spot-DL/pull/5 **Author:** [@ghost](https://github.com/ghost) **Created:** 1/12/2026 **Status:** ❌ Closed **Base:** `k` ← **Head:** `k` --- ### 📝 Commits (10+) - [`a922220`](https://github.com/AmarnathCJD/Spot-DL/commit/a92222083f2067db9de0172cf6e108d48a35d144) Update README.md - [`3c770c1`](https://github.com/AmarnathCJD/Spot-DL/commit/3c770c1e36e8fb93d8c03b91f68a471a7c30b4f1) Merge branch 'master' of https://github.com/amarnathcjd/SpotifyDownloader - [`227e447`](https://github.com/AmarnathCJD/Spot-DL/commit/227e4470c379eb305a22f08ccfba427acac8e8e1) Update s.py - [`c7c2e4c`](https://github.com/AmarnathCJD/Spot-DL/commit/c7c2e4c00497fd05bab2145db63cf82bef08b7a8) Handle lyrics retrieval failure gracefully in get_track function - [`8882a68`](https://github.com/AmarnathCJD/Spot-DL/commit/8882a680684b8dc196bbb2f3082e26be12cf733b) Merge branch 'master' of https://github.com/amarnathcjd/SpotifyDownloader - [`8a4fbed`](https://github.com/AmarnathCJD/Spot-DL/commit/8a4fbed9a8a9526bdbc352155fa8d44408acebb5) Update README.md - [`d17bd7a`](https://github.com/AmarnathCJD/Spot-DL/commit/d17bd7a0669a796ad908a215c27139db920bdc7e) Update README.md - [`d01f30b`](https://github.com/AmarnathCJD/Spot-DL/commit/d01f30b7b675565484669bb8e710b54d0d193081) Rename m.py to lyrics_to_lrc.py - [`bd01adc`](https://github.com/AmarnathCJD/Spot-DL/commit/bd01adce794aedff0bdb81ecda4ce8379f2a44ba) Rename s.py to auth.py - [`b2eeec9`](https://github.com/AmarnathCJD/Spot-DL/commit/b2eeec994df4069033a9f6bc568fc47c18318f10) Add search_track function and handler for querying tracks from Spotify API ### 📊 Changes **65 files changed** (+4608 additions, -22788 deletions) <details> <summary>View changed files</summary> ➕ `.cache` (+1 -0) 📝 `.gitignore` (+5 -1) 📝 `README.md` (+48 -6) ➕ `album_utils.py` (+89 -0) ➕ `artist_utils.py` (+48 -0) ➕ `audio_utils.py` (+26 -0) ➕ `auth.py` (+20 -0) ➕ `config.toml` (+12 -0) 📝 `decrypt.py` (+62 -54) ➕ `filesystem_utils.py` (+13 -0) ➕ `libspot/__init__.py` (+34 -0) ➕ `libspot/audio/__init__.py` (+912 -0) ➕ `libspot/audio/decoders.py` (+122 -0) ➕ `libspot/audio/decrypt.py` (+45 -0) ➕ `libspot/audio/format.py` (+37 -0) ➕ `libspot/audio/storage.py` (+139 -0) ➕ `libspot/cache.py` (+18 -0) 📝 `libspot/core.py` (+1054 -598) 📝 `libspot/crypto.py` (+10 -5) ➕ `libspot/dealer.py` (+11 -0) _...and 45 more files_ </details> ### 📄 Description ### Changes - **New arguments**: - Added arguments for: - `--album` download a specific album, can be combined with `--artist` to refine the search - `--artist` download all albums by an artist - `--url` download by Spotify album/artist URL - `--audio-format` choose between ogg/mp3 - **Names, urls, directories**: - URLs for albums, artists, and tracks are parsed and handled - Uses Spotipy to resolve names from IDs - Album directories are structured appropriately as `<artist>/<album>/...` - **Config file**: - `config.toml` was added for: - `spotify_api_id` developer API key, required for searches - `spotify_api_secret` developer API secret, required for searches - `library_path` export path for downloaded albums - `track_sleep` time to sleep between tracks - `album_sleep` time to sleep between albums - **Original code**: - Existing API endpoints and usage are preserved - CLI and API can be used interchangeably - Starts the same with no CLI args: `python main.py` ### Usage - **CLI Examples:** - Download an album: `python main.py --album "Album Name" --artist "Artist Name"` - Download all albums by an artist: `python main.py --artist "Artist Name"` - Download by Spotify URL: `python main.py --url https://open.spotify.com/album/...` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:17:55 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Spot-DL#4
No description provided.