mirror of
https://github.com/Lambada10/SongSync.git
synced 2026-04-25 22:55:54 +03:00
[GH-ISSUE #136] [Bug] only show songs without lyrics #99
Labels
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SongSync#99
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Turhvjbufv on GitHub (Jan 16, 2025).
Original GitHub issue: https://github.com/Lambada10/SongSync/issues/136
Describe the bug
When only show songs without lyrics is toggled on and you have many songs, the app takes a significant hit in performance
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should be slow a bit on startup but that's it, but it seems like the list of songs isn't cached or something so every change it the app reloades the entire list which is very slow
*Another observation: seems like when excluding a folder it fetched all song and does filtering all over again instead of filtering the already existing list, when unexcluding a folder obviously it needs to refetch everything but it seems like it does it also on excluding it which seems redundant
*Note: I might be wrong about the observations, as I didn't look in the code itself but that's how it felt to me considering how slow it is, it might be that it's just that slow and there's nothing to do, if it is I apologize.
Screenshots
Can provide video proof if needed
Smartphone (please complete the following information):
@Lambada10 commented on GitHub (Jan 17, 2025):
The only way of checking if lyrics exists is to check whether there's a file in expected path, it is time consuming process. I don't see any way of improving that
@Turhvjbufv commented on GitHub (Jan 17, 2025):
That I get, but why when I enter to get lyrics for a song then exit to go back to list of songs it seems to reload the entire list?