[GH-ISSUE #136] [Bug] only show songs without lyrics #99

Closed
opened 2026-02-27 19:26:20 +03:00 by kerem · 2 comments
Owner

Originally created by @Turhvjbufv on GitHub (Jan 16, 2025).
Original GitHub issue: https://github.com/Lambada10/SongSync/issues/136

Describe the bug
When only show songs without lyrics is toggled on and you have many songs, the app takes a significant hit in performance

To Reproduce
Steps to reproduce the behavior:

  1. Have many songs with and without lyrics
  2. Enable only show songs without lyrics
  3. App slows down significantly

Expected behavior
Should be slow a bit on startup but that's it, but it seems like the list of songs isn't cached or something so every change it the app reloades the entire list which is very slow

*Another observation: seems like when excluding a folder it fetched all song and does filtering all over again instead of filtering the already existing list, when unexcluding a folder obviously it needs to refetch everything but it seems like it does it also on excluding it which seems redundant

*Note: I might be wrong about the observations, as I didn't look in the code itself but that's how it felt to me considering how slow it is, it might be that it's just that slow and there's nothing to do, if it is I apologize.

Screenshots
Can provide video proof if needed

Smartphone (please complete the following information):

  • Device: A72
  • OS: lineage os
  • App version 4.2.2
Originally created by @Turhvjbufv on GitHub (Jan 16, 2025). Original GitHub issue: https://github.com/Lambada10/SongSync/issues/136 **Describe the bug** When only show songs without lyrics is toggled on and you have many songs, the app takes a significant hit in performance **To Reproduce** Steps to reproduce the behavior: 1. Have many songs with and without lyrics 2. Enable only show songs without lyrics 3. App slows down significantly **Expected behavior** Should be slow a bit on startup but that's it, but it seems like the list of songs isn't cached or something so every change it the app reloades the entire list which is very slow *Another observation: seems like when excluding a folder it fetched all song and does filtering all over again instead of filtering the already existing list, when unexcluding a folder obviously it needs to refetch everything but it seems like it does it also on excluding it which seems redundant *Note: I might be wrong about the observations, as I didn't look in the code itself but that's how it felt to me considering how slow it is, it might be that it's just that slow and there's nothing to do, if it is I apologize. **Screenshots** Can provide video proof if needed **Smartphone (please complete the following information):** - Device: A72 - OS: lineage os - App version 4.2.2
kerem 2026-02-27 19:26:20 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@Lambada10 commented on GitHub (Jan 17, 2025):

The only way of checking if lyrics exists is to check whether there's a file in expected path, it is time consuming process. I don't see any way of improving that

<!-- gh-comment-id:2598024249 --> @Lambada10 commented on GitHub (Jan 17, 2025): The only way of checking if lyrics exists is to check whether there's a file in expected path, it is time consuming process. I don't see any way of improving that
Author
Owner

@Turhvjbufv commented on GitHub (Jan 17, 2025):

The only way of checking if lyrics exists is to check whether there's a file in expected path, it is time consuming process. I don't see any way of improving that

That I get, but why when I enter to get lyrics for a song then exit to go back to list of songs it seems to reload the entire list?

<!-- gh-comment-id:2598060440 --> @Turhvjbufv commented on GitHub (Jan 17, 2025): > The only way of checking if lyrics exists is to check whether there's a file in expected path, it is time consuming process. I don't see any way of improving that That I get, but why when I enter to get lyrics for a song then exit to go back to list of songs it seems to reload the entire list?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SongSync#99
No description provided.