mirror of
https://github.com/Lambada10/SongSync.git
synced 2026-04-25 22:55:54 +03:00
[GH-ISSUE #117] the artist name section doesn't work #80
Labels
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SongSync#80
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Umbras13 on GitHub (Dec 2, 2024).
Original GitHub issue: https://github.com/Lambada10/SongSync/issues/117
Describe the bug
whenever i search for a lyric to a song it oftens get the wrong song, often for a different artist even tough the artist name has the correct, altough if i put the name of the artist/band it works as expected
To Reproduce
Steps to reproduce the behavior (with the song forest as an example):
Expected behavior
it should filter to show lirycs from the band/artist of the song you selected, instead of having no effect
Screenshots




Smartphone (please complete the following information):
@BobbyESP commented on GitHub (Dec 2, 2024):
This is not an issue of the app but the provider. Anyways we will take a look at what we can do. @Lambada10
@kerollosy commented on GitHub (Dec 6, 2024):
I'm guessing that the provider is LRCLib, because the current impl searches using the song name only:
github.com/Lambada10/SongSync@99785b8f55/app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/LRCLibAPI.kt (L24-L29)I tried to use the api with the song name and artist separated by a space and it worked fine, maybe it should be updated to include the artist name
or we could use
track_nameandartist_nameparameters (instead ofq) in the api search for more accurate resultsI can make a PR if you want me to
@Lambada10 commented on GitHub (Dec 6, 2024):
I completely forgot about that part, I'll revert it