starred/SongSync
1
0
Fork 0
mirror of https://github.com/Lambada10/SongSync.git synced 2026-04-25 22:55:54 +03:00
Code Issues 58 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #97] Filter songs that already has lyrics, isnt working #69

New issue
Closed
opened 2026-02-27 19:26:10 +03:00 by kerem · 7 comments
kerem commented 2026-02-27 19:26:10 +03:00
Owner
Copy link

Originally created by @kingmadwik on GitHub (Oct 23, 2024).
Original GitHub issue: https://github.com/Lambada10/SongSync/issues/97

Describe the bug
This feature wasnt working for me from many releases. I tried changing options to see if anything was causing problems but nothing worked

Screenshot_2024-10-24-01-43-24-41_372870d89fd5f8ba7a994f975f281c90

i have lyrics for most songs but it still include them in the list of non-lyrics songs

Originally created by @kingmadwik on GitHub (Oct 23, 2024). Original GitHub issue: https://github.com/Lambada10/SongSync/issues/97 **Describe the bug** This feature wasnt working for me from many releases. I tried changing options to see if anything was causing problems but nothing worked ![Screenshot_2024-10-24-01-43-24-41_372870d89fd5f8ba7a994f975f281c90](https://github.com/user-attachments/assets/f72a17ff-a4c9-4dbf-999e-4e1fd8f9744b) i have lyrics for most songs but it still include them in the list of non-lyrics songs
kerem 2026-02-27 19:26:10 +03:00
  • closed this issue
  • added the
    bug
         label
kerem commented 2026-02-27 19:26:10 +03:00
Author
Owner
Copy link

@kingmadwik commented on GitHub (Oct 25, 2024):

Okay lyrics detection worksfor embedded lyrics or only .LRC files only ?

<!-- gh-comment-id:2437951041 --> @kingmadwik commented on GitHub (Oct 25, 2024): Okay lyrics detection worksfor embedded lyrics or only .LRC files only ?
kerem commented 2026-02-27 19:26:10 +03:00
Author
Owner
Copy link

@Lambada10 commented on GitHub (Oct 25, 2024):

@kingmadwik Current impl looks for a LRC file named the same as song file to check if it has lyrics already

<!-- gh-comment-id:2437955828 --> @Lambada10 commented on GitHub (Oct 25, 2024): @kingmadwik Current impl looks for a LRC file named the same as song file to check if it has lyrics already
kerem commented 2026-02-27 19:26:11 +03:00
Author
Owner
Copy link

@kingmadwik commented on GitHub (Oct 25, 2024):

@Lambada10 then this isnt a bug at all, im sorry for wasting your time. Maybe you can consider adding a feature that checks for embedded lyrics and then show them in the no lyrics section. thanks for the app

<!-- gh-comment-id:2438381331 --> @kingmadwik commented on GitHub (Oct 25, 2024): @Lambada10 then this isnt a bug at all, im sorry for wasting your time. Maybe you can consider adding a feature that checks for embedded lyrics and then show them in the no lyrics section. thanks for the app
kerem commented 2026-02-27 19:26:11 +03:00
Author
Owner
Copy link

@kerollosy commented on GitHub (Oct 26, 2024):

@Lambada10 then this isnt a bug at all, im sorry for wasting your time. Maybe you can consider adding a feature that checks for embedded lyrics and then show them in the no lyrics section. thanks for the app

I can work on this if lambada isn't already

<!-- gh-comment-id:2439643258 --> @kerollosy commented on GitHub (Oct 26, 2024): > @Lambada10 then this isnt a bug at all, im sorry for wasting your time. Maybe you can consider adding a feature that checks for embedded lyrics and then show them in the no lyrics section. thanks for the app I can work on this if lambada isn't already
kerem commented 2026-02-27 19:26:11 +03:00
Author
Owner
Copy link

@bugreporter005 commented on GitHub (Dec 10, 2024):

Any updates on that?

<!-- gh-comment-id:2532734447 --> @bugreporter005 commented on GitHub (Dec 10, 2024): Any updates on that?
kerem commented 2026-02-27 19:26:11 +03:00
Author
Owner
Copy link

@kerollosy commented on GitHub (Dec 11, 2024):

It seems the only way to check if a song has embedded lyrics is to read the entire metadata of the song using TagLib, but unfortunately this process can be quite slow and would cause a significant delay in loading the app

<!-- gh-comment-id:2536168228 --> @kerollosy commented on GitHub (Dec 11, 2024): It seems the only way to check if a song has embedded lyrics is to read the entire metadata of the song using TagLib, but unfortunately this process can be quite slow and would cause a significant delay in loading the app
kerem commented 2026-02-27 19:26:11 +03:00
Author
Owner
Copy link

@kingmadwik commented on GitHub (Dec 29, 2024):

It seems the only way to check if a song has embedded lyrics is to read the entire metadata of the song using TagLib, but unfortunately this process can be quite slow and would cause a significant delay in loading the app

Ohk then maybe untill we find out better way to do this, its not worth it. Thanks for the reply.

<!-- gh-comment-id:2564674230 --> @kingmadwik commented on GitHub (Dec 29, 2024): > It seems the only way to check if a song has embedded lyrics is to read the entire metadata of the song using TagLib, but unfortunately this process can be quite slow and would cause a significant delay in loading the app Ohk then maybe untill we find out better way to do this, its not worth it. Thanks for the reply.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feat/now-playing
v4.3.3
v4.3.2
v4.3.1
v4.3.0
v4.2.2
v4.2.1
v4.2.0
v4.1.0
v4.0.0
v3.0.3
v3.0.2
v3.0.1
v3.0.0
v2.2.0
v2.1.0
v2.0.0
v1.3
v1.2
v1.1
v1.0
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
wontfix
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SongSync#69
No description provided.