mirror of
https://github.com/Lambada10/SongSync.git
synced 2026-04-25 22:55:54 +03:00
[GH-ISSUE #90] Timecode change #65
Labels
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SongSync#65
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Anonuser-01 on GitHub (Oct 16, 2024).
Original GitHub issue: https://github.com/Lambada10/SongSync/issues/90
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I sometimes download songs from YouTube and it tends to have some non song audio, such as extra long music or other audio. This causes the time synced lyrics downloaded from SongSync to not match up.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Allow to adjust the synced lyrics time codes by adding or subtracting when the lyrics are played.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
N/A
Additional context
Add any other context or screenshots about the feature request here.
Implementation would be similar to some video players with subtitle support that allow adjusting the time codes to line up with the film audio.
@Lambada10 commented on GitHub (Oct 17, 2024):
Hi,
I assume you mean to set the offset on the specific song screen, as it wouldn't make sense on batch downloads.
Could you test if this works as intended?
https://github.com/Lambada10/SongSync/actions/runs/11383707236/artifacts/2068387473
@Anonuser-01 commented on GitHub (Oct 17, 2024):
Hi, yes I meant on the song screen. This looks nice, and I can change the offset in the app, but the time does not show in the lyrics within the app and also when I export it as lrc.
Also, as you can see in the image, I had to offset by several seconds which takes time to do with the .1 offset so it would be nice to see a 1 second offset next to the .1 offset. You'll probably have to shrink the .1 button a bit to add the 1 second next to it. What could also work is if I can hold on the .1 offset button and it changes quick instead of having to press it for each change.
Thanks!
@Lambada10 commented on GitHub (Oct 17, 2024):
The timestamp does not change as there's dedicated offset LRC tag.
https://en.m.wikipedia.org/wiki/LRC_(file_format)#File_format
@Anonuser-01 commented on GitHub (Oct 17, 2024):
Oh interesting. Didn't know that! Unfortunately I have tried it with several players and none of them seem to support the offset tag.
I guess it's not a standard according to the article you shared:
"ID tags may optionally appear before the lyrics,[2] although some players may not recognize or simply ignore this"
Are you able to make it so when I change the offset, it changes the time codes by that amount? I don't think it would be that difficult to implement because if the time add is 10 seconds, you would just need to add 10 seconds to all the timecodes.
Thanks