starred/SongSync
1
0
Fork 0
mirror of https://github.com/Lambada10/SongSync.git synced 2026-04-25 14:45:51 +03:00
Code Issues 58 Projects Releases 10 Packages Wiki Activity

[PR #166] [MERGED] Animated Dropdowns and other fixes #203

New issue
Closed
opened 2026-02-27 19:26:45 +03:00 by kerem · 0 comments
kerem commented 2026-02-27 19:26:45 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/166
Author: @pxeemo
Created: 4/10/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @Lambada10

Base: master ← Head: master

📝 Commits (10+)

  • b162d0d move embed checkbox from HomeScreen DropDown to batch download dialog
  • 3b9a9ac fix: search matching not updating the list
  • 4925684 feat: back to cancel search
  • 6df1d0b fix: PaxMusicHelper.kt: prevent duplicate timestamps
  • 8f47f4b feat: Add word-by-word badge
  • 426b09b feat: Allow changing provider from LyricsFetchScreen
  • 6e314dc feat: Add delay for closing ProvidersDropdownMenu.kt
  • 4919e72 fix: Use resources plurals for total songs
  • 7c8cb18 fix: strings: filter no lyrics and plural total songs
  • 74bc8f3 feat: Added AnimatedDropDown

📊 Changes

20 files changed (+1015 additions, -167 deletions)

View changed files

📝 app/src/main/java/pl/lambada/songsync/data/remote/PaxMusicHelper.kt (+18 -17)
➕ app/src/main/java/pl/lambada/songsync/ui/components/ProvidersDropdownMenu.kt (+124 -0)
➕ app/src/main/java/pl/lambada/songsync/ui/components/dropdown/AnimatedDropdownMenu.kt (+124 -0)
➕ app/src/main/java/pl/lambada/songsync/ui/components/dropdown/DropdownMenuImplementation.kt (+507 -0)
➕ app/src/main/java/pl/lambada/songsync/ui/components/dropdown/M3ElevationTokens.kt (+15 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeScreen.kt (+0 -3)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/BatchDownloadLyrics.kt (+3 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/FilterAndSongCount.kt (+2 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/FiltersDialog.kt (+2 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/HomeAppBar.kt (+0 -4)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/HomeSearchBar.kt (+10 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/HomeTopAppBarDropDown.kt (+87 -111)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/SortDialog.kt (+1 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/components/batchDownload/BatchDownloadWarningDialog.kt (+31 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchScreen.kt (+35 -2)
➕ app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/CloudProviderTitle.kt (+35 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/SuccessContent.kt (+8 -17)
📝 app/src/main/java/pl/lambada/songsync/util/LyricsUtils.kt (+7 -8)
📝 app/src/main/res/values/strings.xml (+5 -1)

📄 Description

Fixed:

  • Search not resetting when the result is an empty list
  • Duplicate timestamps appearing
  • Ending '>' in lyrics being removed
  • Use string resources for total songs title

Added:

  • Animated drop down menus thanks to @BobbyESP
  • Providers drop down menu on search screen
  • Press back to cancel the search

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/166 **Author:** [@pxeemo](https://github.com/pxeemo) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`b162d0d`](https://github.com/Lambada10/SongSync/commit/b162d0dd08e696097dba7806ec2190205aa6fc4c) move embed checkbox from HomeScreen DropDown to batch download dialog - [`3b9a9ac`](https://github.com/Lambada10/SongSync/commit/3b9a9ac1811713d39d3f2a07c07c36e97cf400f2) fix: search matching not updating the list - [`4925684`](https://github.com/Lambada10/SongSync/commit/49256849814463fc9652aa8b6fece415cb8acc5b) feat: back to cancel search - [`6df1d0b`](https://github.com/Lambada10/SongSync/commit/6df1d0b86ed399c456987aad3308b0df9ac764aa) fix: PaxMusicHelper.kt: prevent duplicate timestamps - [`8f47f4b`](https://github.com/Lambada10/SongSync/commit/8f47f4b17cd8660f8ffb869d9f2286330dee9af6) feat: Add word-by-word badge - [`426b09b`](https://github.com/Lambada10/SongSync/commit/426b09bf70e110532d972bfad91d62b01fe8bf5f) feat: Allow changing provider from LyricsFetchScreen - [`6e314dc`](https://github.com/Lambada10/SongSync/commit/6e314dc4abbd76a310b019a19b57ccca267fde7d) feat: Add delay for closing ProvidersDropdownMenu.kt - [`4919e72`](https://github.com/Lambada10/SongSync/commit/4919e72adf93f727df187c932731682739760328) fix: Use resources plurals for total songs - [`7c8cb18`](https://github.com/Lambada10/SongSync/commit/7c8cb183a33694dc5677596524ea028282bed143) fix: strings: filter no lyrics and plural total songs - [`74bc8f3`](https://github.com/Lambada10/SongSync/commit/74bc8f3657d7b0f116159e03c2ce6d881bbac068) feat: Added AnimatedDropDown ### 📊 Changes **20 files changed** (+1015 additions, -167 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/pl/lambada/songsync/data/remote/PaxMusicHelper.kt` (+18 -17) ➕ `app/src/main/java/pl/lambada/songsync/ui/components/ProvidersDropdownMenu.kt` (+124 -0) ➕ `app/src/main/java/pl/lambada/songsync/ui/components/dropdown/AnimatedDropdownMenu.kt` (+124 -0) ➕ `app/src/main/java/pl/lambada/songsync/ui/components/dropdown/DropdownMenuImplementation.kt` (+507 -0) ➕ `app/src/main/java/pl/lambada/songsync/ui/components/dropdown/M3ElevationTokens.kt` (+15 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeScreen.kt` (+0 -3) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/BatchDownloadLyrics.kt` (+3 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/FilterAndSongCount.kt` (+2 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/FiltersDialog.kt` (+2 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/HomeAppBar.kt` (+0 -4) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/HomeSearchBar.kt` (+10 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/HomeTopAppBarDropDown.kt` (+87 -111) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/SortDialog.kt` (+1 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/components/batchDownload/BatchDownloadWarningDialog.kt` (+31 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchScreen.kt` (+35 -2) ➕ `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/CloudProviderTitle.kt` (+35 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/SuccessContent.kt` (+8 -17) 📝 `app/src/main/java/pl/lambada/songsync/util/LyricsUtils.kt` (+7 -8) 📝 `app/src/main/res/values/strings.xml` (+5 -1) </details> ### 📄 Description Fixed: - Search not resetting when the result is an empty list - Duplicate timestamps appearing - Ending '>' in lyrics being removed - Use string resources for total songs title Added: - Animated drop down menus thanks to @BobbyESP - Providers drop down menu on search screen - Press back to cancel the search --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 19:26:45 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feat/now-playing
v4.3.3
v4.3.2
v4.3.1
v4.3.0
v4.2.2
v4.2.1
v4.2.0
v4.1.0
v4.0.0
v3.0.3
v3.0.2
v3.0.1
v3.0.0
v2.2.0
v2.1.0
v2.0.0
v1.3
v1.2
v1.1
v1.0
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
wontfix
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SongSync#203
No description provided.