[PR #95] [MERGED] Add Synced/Unsynced Lyrics Toggle and Refactor Musixmatch API, closes #91 #188

New issue

Closed

opened 2026-02-27 19:26:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/95
Author: @kerollosy
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @Lambada10

Base: master ← Head: musixmatch

📝 Commits (10+)

5defad6 Replaced the search endpoint with the full lyrics endpoint.
d8fd45a Refactor and split MusixmatchLyricsResponse into Synced and Unsynced lyrics data classes
cf141bc (api:update) Refactor SongInfo model to include Musixmatch synced and unsynced lyrics data
2f610b9 Save the SongInfo object and use it to retreive data
589d35b Merge branch 'Lambada10:master' into musixmatch
522ee34 Add SyncedLyricsSwitch component #91
b7f5ec9 Merge branch 'musixmatch' of https://github.com/kerollosy/SongSync into musixmatch
26a7b88 Update string resources
8eaf77e Update UserSettingsController and AboutScreen
e2df61f Refactor MusixmatchAPI to separate synced and unsynced lyrics retrieval

📊 Changes

10 files changed (+90 additions, -33 deletions)

View changed files

📝 app/src/main/java/pl/lambada/songsync/data/remote/UserSettingsController.kt (+9 -0)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt (+9 -5)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/MusixmatchAPI.kt (+24 -24)
📝 app/src/main/java/pl/lambada/songsync/domain/model/SongInfo.kt (+4 -0)
📝 app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/Musixmatch.kt (+12 -2)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/about/AboutScreen.kt (+8 -0)
➕ app/src/main/java/pl/lambada/songsync/ui/screens/about/components/SyncedLyricsSwitch.kt (+18 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt (+2 -1)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt (+2 -1)
📝 app/src/main/res/values/strings.xml (+2 -0)

📄 Description

Added a toggle switch component ("Get Synced Lyrics") to allow users to choose between synced and unsynced lyrics from Musixmatch.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/95 **Author:** [@kerollosy](https://github.com/kerollosy) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `musixmatch` --- ### 📝 Commits (10+) - [`5defad6`](https://github.com/Lambada10/SongSync/commit/5defad6cd1e113f2749097f39f8e2fec116fb62f) Replaced the search endpoint with the full lyrics endpoint. - [`d8fd45a`](https://github.com/Lambada10/SongSync/commit/d8fd45afda9f7724c1a9502ced6491fa6f578dac) Refactor and split MusixmatchLyricsResponse into Synced and Unsynced lyrics data classes - [`cf141bc`](https://github.com/Lambada10/SongSync/commit/cf141bcc0b62c93af26885c8a5c05ff6efcefb58) (api:update) Refactor SongInfo model to include Musixmatch synced and unsynced lyrics data - [`2f610b9`](https://github.com/Lambada10/SongSync/commit/2f610b9d5298635289a8466107313263263765ee) Save the SongInfo object and use it to retreive data - [`589d35b`](https://github.com/Lambada10/SongSync/commit/589d35b48bb9b7cf14fbe746b4aa96e2552155a1) Merge branch 'Lambada10:master' into musixmatch - [`522ee34`](https://github.com/Lambada10/SongSync/commit/522ee3478653870d49ace73473c14abb95e170a4) Add SyncedLyricsSwitch component #91 - [`b7f5ec9`](https://github.com/Lambada10/SongSync/commit/b7f5ec95bc6a6bd691dc3933f878857a346a8bf6) Merge branch 'musixmatch' of https://github.com/kerollosy/SongSync into musixmatch - [`26a7b88`](https://github.com/Lambada10/SongSync/commit/26a7b8838a87e9fb785485c4e419edc2419a786c) Update string resources - [`8eaf77e`](https://github.com/Lambada10/SongSync/commit/8eaf77e424427933e56709a04de57685889b4d8f) Update UserSettingsController and AboutScreen - [`e2df61f`](https://github.com/Lambada10/SongSync/commit/e2df61f396aa224e4d7e91f89445a0d948fcdbe2) Refactor MusixmatchAPI to separate synced and unsynced lyrics retrieval ### 📊 Changes **10 files changed** (+90 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/pl/lambada/songsync/data/remote/UserSettingsController.kt` (+9 -0) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt` (+9 -5) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/MusixmatchAPI.kt` (+24 -24) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/SongInfo.kt` (+4 -0) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/Musixmatch.kt` (+12 -2) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/about/AboutScreen.kt` (+8 -0) ➕ `app/src/main/java/pl/lambada/songsync/ui/screens/about/components/SyncedLyricsSwitch.kt` (+18 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/home/HomeViewModel.kt` (+2 -1) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt` (+2 -1) 📝 `app/src/main/res/values/strings.xml` (+2 -0) </details> ### 📄 Description Added a toggle switch component ("Get Synced Lyrics") to allow users to choose between synced and unsynced lyrics from Musixmatch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>