[PR #92] [MERGED] Feat/offset, closes #90 #185

Closed
opened 2026-02-27 19:26:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/92
Author: @Lambada10
Created: 10/21/2024
Status: Merged
Merged: 10/24/2024
Merged by: @Lambada10

Base: masterHead: feat/offset


📝 Commits (5)

  • 9a0117a Initial implementation of setting lyrics offset
  • 5a0b81d correct button values according to text displayed
  • 47cb72c Add repeating clickable to offset change #90
  • 8cd1484 Apply offset to lyrics directly #90
  • 4080640 Merge branch 'master' into feat/offset

📊 Changes

7 files changed (+198 additions, -7 deletions)

View changed files

📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchScreen.kt (+10 -2)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt (+3 -2)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/LyricsSuccessContent.kt (+72 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/SuccessContent.kt (+7 -1)
📝 app/src/main/java/pl/lambada/songsync/util/LyricsUtils.kt (+43 -2)
📝 app/src/main/java/pl/lambada/songsync/util/ext/ComposeExt.kt (+62 -0)
📝 app/src/main/res/values/strings.xml (+1 -0)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/92 **Author:** [@Lambada10](https://github.com/Lambada10) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `feat/offset` --- ### 📝 Commits (5) - [`9a0117a`](https://github.com/Lambada10/SongSync/commit/9a0117ac184d901be683ac3e7f718411363f3000) Initial implementation of setting lyrics offset - [`5a0b81d`](https://github.com/Lambada10/SongSync/commit/5a0b81df587bb3d3ab97a67066e4b9c11a4683d7) correct button values according to text displayed - [`47cb72c`](https://github.com/Lambada10/SongSync/commit/47cb72c7adefd85f569fcb43432f37c74978c260) Add repeating clickable to offset change #90 - [`8cd1484`](https://github.com/Lambada10/SongSync/commit/8cd14842aff9ece21915a46f48ca9d657049b698) Apply offset to lyrics directly #90 - [`4080640`](https://github.com/Lambada10/SongSync/commit/4080640b85b87b249e656dfbe98a80e985df0553) Merge branch 'master' into feat/offset ### 📊 Changes **7 files changed** (+198 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchScreen.kt` (+10 -2) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/LyricsFetchViewModel.kt` (+3 -2) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/LyricsSuccessContent.kt` (+72 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/lyricsFetch/components/SuccessContent.kt` (+7 -1) 📝 `app/src/main/java/pl/lambada/songsync/util/LyricsUtils.kt` (+43 -2) 📝 `app/src/main/java/pl/lambada/songsync/util/ext/ComposeExt.kt` (+62 -0) 📝 `app/src/main/res/values/strings.xml` (+1 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 19:26:41 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SongSync#185
No description provided.