mirror of
https://github.com/Lambada10/SongSync.git
synced 2026-04-25 22:55:54 +03:00
[PR #88] [MERGED] Add Musixmatch API Integration #184
Labels
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SongSync#184
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Lambada10/SongSync/pull/88
Author: @kerollosy
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @Lambada10
Base:
master← Head:musixmatch📝 Commits (9)
b23dfd2Add support for Musixmatch lyrics providerd5a28f5TODO: Handle Musixmatch provider selectedc5423b8AddedmusixmatchIDto track Musixmatch song ID7c30117Add musixmatchID field to SongInfo model656b2d5Add MusixmatchAPI class for searching and retrieving synced lyrics83fffdffix: correct data type for Musixmatch album_id in search responseb11d2fcrefactor: rename fields in Musixmatch response models for consistency59429c0fix: correct Musixmatch API usage in LyricsProviderService6522e63feat: add separate fields for synced and unsynced lyrics to Musixmatch API response📊 Changes
5 files changed (+111 additions, -1 deletions)
View changed files
📝
app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/LyricsProviderService.kt(+9 -0)➕
app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/MusixmatchAPI.kt(+72 -0)📝
app/src/main/java/pl/lambada/songsync/domain/model/SongInfo.kt(+1 -0)➕
app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/Musixmatch.kt(+27 -0)📝
app/src/main/java/pl/lambada/songsync/util/LyricsUtils.kt(+2 -1)📄 Description
This PR adds support for Musixmatch as a lyrics provider, allowing synced lyrics to be retrieved from the Musixmatch API.
Musixmatch is the best lyrics provider afaik
I implemented my own server to filter the Musixmatch output, ensuring compatibility with SongSync's format
I learned kotlin just to make this PR
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.