[PR #75] [MERGED] fix: remove unnecessary manual encoding of parameter #179

New issue

Closed

opened 2026-02-27 19:26:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/75
Author: @Risuntsy
Created: 7/29/2024
Status: ✅ Merged
Merged: 8/12/2024
Merged by: @Lambada10

Base: master ← Head: master

📝 Commits (1)

cac6e61 fix: remove unnecessary manual encoding of parameter

📊 Changes

1 file changed (+3 additions, -7 deletions)

View changed files

📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/NeteaseAPI.kt (+3 -7)

📄 Description

The HttpClient seems to handle escaping internally. Manual escaping (in the NetEase API part) may lead to duplicate escaping and cause unexpected results if there are special characters in the song name or artist name.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/75 **Author:** [@Risuntsy](https://github.com/Risuntsy) **Created:** 7/29/2024 **Status:** ✅ Merged **Merged:** 8/12/2024 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cac6e61`](https://github.com/Lambada10/SongSync/commit/cac6e61af9a6dc6b218bbbf24e70ede0679717b6) fix: remove unnecessary manual encoding of parameter ### 📊 Changes **1 file changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/NeteaseAPI.kt` (+3 -7) </details> ### 📄 Description The HttpClient seems to handle escaping internally. Manual escaping (in the NetEase API part) may lead to duplicate escaping and cause unexpected results if there are special characters in the song name or artist name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>