[PR #50] [MERGED] General improvements and optimizations #176

New issue

Closed

opened 2026-02-27 19:26:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/50
Author: @BobbyESP
Created: 11/17/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @Lambada10

Base: master ← Head: master

📝 Commits (9)

b96a700 feat: Made pure black applied with no restart needed.
ac1e37d refactor: Deleted unnecessary DTOs and moved the existing ones to the model package
05d72b8 refactor: Deleted DTOs from data package
ef9c3a7 refactor: Moved data type extensions to the util package
7ce184e perf: Deleted unnecessary Json and HttpClient instances
1c4f948 fix: Removed client functions that made it being closed
2b3e3a5 feat(DEV-Info): Info/help for creating the proxy server of issue #44
5f2c933 ui: Made SongCard song's name font weight SemiBold
977074c fix: App crashing because of bad quantity for plurals in Spanish strings

📊 Changes

51 files changed (+782 additions, -649 deletions)

View changed files

➕ .idea/appInsightsSettings.xml (+26 -0)
📝 .idea/gradle.xml (+1 -1)
📝 app/src/main/AndroidManifest.xml (+3 -2)
📝 app/src/main/java/pl/lambada/songsync/MainActivity.kt (+86 -79)
📝 app/src/main/java/pl/lambada/songsync/data/MainViewModel.kt (+40 -20)
➖ app/src/main/java/pl/lambada/songsync/data/api/GithubAPI.kt (+0 -34)
➖ app/src/main/java/pl/lambada/songsync/data/dto/GithubReleaseDTO.kt (+0 -13)
➖ app/src/main/java/pl/lambada/songsync/data/dto/Release.kt (+0 -11)
➕ app/src/main/java/pl/lambada/songsync/data/remote/github/GithubAPI.kt (+23 -0)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/LRCLibAPI.kt (+15 -17)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/NeteaseAPI.kt (+20 -24)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/spotify/SpotifyAPI.kt (+21 -20)
📝 app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/spotify/SpotifyLyricsAPI.kt (+6 -10)
➕ app/src/main/java/pl/lambada/songsync/domain/model/Release.kt (+17 -0)
📝 app/src/main/java/pl/lambada/songsync/domain/model/Song.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/domain/model/SongInfo.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/LRCLib.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/Netease.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/spotify/AccessToken.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/spotify/SpotifyApi.kt (+1 -1)

...and 31 more files

📄 Description

What has changed?

To start clarify that almost non part of the app has been afected itself, just the code has been improved and refactored to achieve the Kotlin code standarts.

Deleted all the Ktor HttpEngine instances and left just one common for all (the same with the Json parser)
Moved all DTOs to the new domain package and deleted some unnecessary.
Made the GitHub API class an object
Made the "Pure Black" switch perform in real time and not when restarting the app

Hope you like these changes!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/50 **Author:** [@BobbyESP](https://github.com/BobbyESP) **Created:** 11/17/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`b96a700`](https://github.com/Lambada10/SongSync/commit/b96a70082fdb9d5f07c5c03530f8451589fef9b6) feat: Made pure black applied with no restart needed. - [`ac1e37d`](https://github.com/Lambada10/SongSync/commit/ac1e37d051e58d9b2ce1052b9d9c46726c31d3ef) refactor: Deleted unnecessary DTOs and moved the existing ones to the model package - [`05d72b8`](https://github.com/Lambada10/SongSync/commit/05d72b8d37dbefa9db36a6a4606de63f64c7456e) refactor: Deleted DTOs from data package - [`ef9c3a7`](https://github.com/Lambada10/SongSync/commit/ef9c3a7afcfbe1ceaa3b413b26773f43724e6b20) refactor: Moved data type extensions to the `util` package - [`7ce184e`](https://github.com/Lambada10/SongSync/commit/7ce184e9316d6a1ef2c9e2c5e49ed58a7151c7d8) perf: Deleted unnecessary Json and HttpClient instances - [`1c4f948`](https://github.com/Lambada10/SongSync/commit/1c4f948a8413e134035b7a46b189e48f9fa6a609) fix: Removed client functions that made it being closed - [`2b3e3a5`](https://github.com/Lambada10/SongSync/commit/2b3e3a5f933920d076254bb4cf8f2409e8b7d58a) feat(DEV-Info): Info/help for creating the proxy server of issue #44 - [`5f2c933`](https://github.com/Lambada10/SongSync/commit/5f2c933b66af7d07bc360d1e7650a7770db24b63) ui: Made SongCard song's name font weight SemiBold - [`977074c`](https://github.com/Lambada10/SongSync/commit/977074c12268420547b56ec08d389431738f66e1) fix: App crashing because of bad `quantity` for plurals in Spanish strings ### 📊 Changes **51 files changed** (+782 additions, -649 deletions) <details> <summary>View changed files</summary> ➕ `.idea/appInsightsSettings.xml` (+26 -0) 📝 `.idea/gradle.xml` (+1 -1) 📝 `app/src/main/AndroidManifest.xml` (+3 -2) 📝 `app/src/main/java/pl/lambada/songsync/MainActivity.kt` (+86 -79) 📝 `app/src/main/java/pl/lambada/songsync/data/MainViewModel.kt` (+40 -20) ➖ `app/src/main/java/pl/lambada/songsync/data/api/GithubAPI.kt` (+0 -34) ➖ `app/src/main/java/pl/lambada/songsync/data/dto/GithubReleaseDTO.kt` (+0 -13) ➖ `app/src/main/java/pl/lambada/songsync/data/dto/Release.kt` (+0 -11) ➕ `app/src/main/java/pl/lambada/songsync/data/remote/github/GithubAPI.kt` (+23 -0) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/LRCLibAPI.kt` (+15 -17) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/others/NeteaseAPI.kt` (+20 -24) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/spotify/SpotifyAPI.kt` (+21 -20) 📝 `app/src/main/java/pl/lambada/songsync/data/remote/lyrics_providers/spotify/SpotifyLyricsAPI.kt` (+6 -10) ➕ `app/src/main/java/pl/lambada/songsync/domain/model/Release.kt` (+17 -0) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/Song.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/SongInfo.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/LRCLib.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/others/Netease.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/spotify/AccessToken.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/domain/model/lyrics_providers/spotify/SpotifyApi.kt` (+1 -1) _...and 31 more files_ </details> ### 📄 Description ## What has changed? To start clarify that almost non part of the app has been afected itself, just the code has been improved and refactored to achieve the Kotlin code standarts. - Deleted all the Ktor HttpEngine instances and left just one common for all (the same with the Json parser) - Moved all DTOs to the new `domain` package and deleted some unnecessary. - Made the GitHub API class an object - Made the "Pure Black" switch perform in real time and not when restarting the app Hope you like these changes! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>