[PR #3] [MERGED] Added Spanish translations and other minor changes #164

New issue

Closed

opened 2026-02-27 19:26:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 19:26:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Lambada10/SongSync/pull/3
Author: @BobbyESP
Created: 6/25/2023
Status: ✅ Merged
Merged: 6/26/2023
Merged by: @Lambada10

Base: master ← Head: master

📝 Commits (3)

8ab6e32 - Added Spanish translations
c71c05f - Fixed Spanish string not showing good the percentage in Batch Download Lyrics
bc8f40b - Moved JSON parsing to Serializable data classes so kotlinx.serialization can decode the server response into code

📊 Changes

15 files changed (+416 additions, -100 deletions)

View changed files

📝 app/src/main/java/pl/lambada/songsync/MainActivity.kt (+38 -36)
📝 app/src/main/java/pl/lambada/songsync/data/MainViewModel.kt (+80 -35)
📝 app/src/main/java/pl/lambada/songsync/data/Screens.kt (+11 -0)
➕ app/src/main/java/pl/lambada/songsync/data/dto/AccessTokenDto.kt (+10 -0)
📝 app/src/main/java/pl/lambada/songsync/data/dto/Song.kt (+1 -1)
📝 app/src/main/java/pl/lambada/songsync/data/dto/SongInfo.kt (+1 -1)
➕ app/src/main/java/pl/lambada/songsync/data/dto/SpotifyApiDTOs.kt (+99 -0)
➕ app/src/main/java/pl/lambada/songsync/data/dto/SpotifySyncedLyricsApiDTOs.kt (+16 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/components/AppBars.kt (+23 -12)
➕ app/src/main/java/pl/lambada/songsync/ui/components/dialogs/NoInternetDialog.kt (+26 -0)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/AboutScreen.kt (+5 -4)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/BrowseScreen.kt (+4 -4)
📝 app/src/main/java/pl/lambada/songsync/ui/screens/HomeScreen.kt (+3 -3)
➕ app/src/main/res/values-es/strings.xml (+79 -0)
📝 app/src/main/res/values/strings.xml (+20 -4)

📄 Description

Added Spanish translations
Moved NoInternetDialog to another separated file
Made page headers translatable
Added context to the MainActivity companion object
Moved contributors arguments to an enum class
Moved other hard-coded strings to XML declaration
Replaced a Thread with coroutine (the last standing XD)
Made the bottom nav bar items not navigable when you already are in it

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Lambada10/SongSync/pull/3 **Author:** [@BobbyESP](https://github.com/BobbyESP) **Created:** 6/25/2023 **Status:** ✅ Merged **Merged:** 6/26/2023 **Merged by:** [@Lambada10](https://github.com/Lambada10) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`8ab6e32`](https://github.com/Lambada10/SongSync/commit/8ab6e32a21bf70fbb7f134834d7b172046607d99) - Added Spanish translations - [`c71c05f`](https://github.com/Lambada10/SongSync/commit/c71c05fc32fcd75c38912079c0d53e9a7f92bc59) - Fixed Spanish string not showing good the percentage in `Batch Download Lyrics` - [`bc8f40b`](https://github.com/Lambada10/SongSync/commit/bc8f40b8eb34edb7ff13ecb1cf1fdee18217c83e) - Moved JSON parsing to Serializable data classes so kotlinx.serialization can decode the server response into code ### 📊 Changes **15 files changed** (+416 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/pl/lambada/songsync/MainActivity.kt` (+38 -36) 📝 `app/src/main/java/pl/lambada/songsync/data/MainViewModel.kt` (+80 -35) 📝 `app/src/main/java/pl/lambada/songsync/data/Screens.kt` (+11 -0) ➕ `app/src/main/java/pl/lambada/songsync/data/dto/AccessTokenDto.kt` (+10 -0) 📝 `app/src/main/java/pl/lambada/songsync/data/dto/Song.kt` (+1 -1) 📝 `app/src/main/java/pl/lambada/songsync/data/dto/SongInfo.kt` (+1 -1) ➕ `app/src/main/java/pl/lambada/songsync/data/dto/SpotifyApiDTOs.kt` (+99 -0) ➕ `app/src/main/java/pl/lambada/songsync/data/dto/SpotifySyncedLyricsApiDTOs.kt` (+16 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/components/AppBars.kt` (+23 -12) ➕ `app/src/main/java/pl/lambada/songsync/ui/components/dialogs/NoInternetDialog.kt` (+26 -0) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/AboutScreen.kt` (+5 -4) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/BrowseScreen.kt` (+4 -4) 📝 `app/src/main/java/pl/lambada/songsync/ui/screens/HomeScreen.kt` (+3 -3) ➕ `app/src/main/res/values-es/strings.xml` (+79 -0) 📝 `app/src/main/res/values/strings.xml` (+20 -4) </details> ### 📄 Description - Added Spanish translations - Moved NoInternetDialog to another separated file - Made page headers translatable - Added context to the MainActivity companion object - Moved contributors arguments to an enum class - Moved other hard-coded strings to XML declaration - Replaced a Thread with coroutine (the last standing XD) - Made the bottom nav bar items not navigable when you already are in it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>