mirror of
https://github.com/Lambada10/SongSync.git
synced 2026-04-25 14:45:51 +03:00
[GH-ISSUE #192] Batch downloading lyrics always calls Spotify API even when Spotify is not selected as provider #143
Labels
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SongSync#143
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @VipulNerd on GitHub (Oct 1, 2025).
Original GitHub issue: https://github.com/Lambada10/SongSync/issues/192
Originally assigned to: @VipulNerd on GitHub.
📌 Description
While using the Batch Download feature, SongSync still triggers Spotify API requests even if Spotify is not selected as a lyrics provider.
This causes unnecessary API calls and leads to Spotify rate limiting, which affects downloads even when the user doesn’t intend to use Spotify.
⸻
🎯 Expected Behavior
If Spotify is not selected as a provider, the app should skip all Spotify API calls during batch downloads.
⸻
💡 Possible Solution
The issue likely originates in LyricsRepository.kt, where all providers are included in the Flow by default.
Proposed fix:
• Filter providers based on user settings before batch processing.
• Add a guard check in LyricsRepository before invoking SpotifyProvider.
This ensures that Spotify is only queried when the user explicitly enables it.
⸻
🙋 Request
I’d like to work on this issue as part of Hacktoberfest 2025.
@Lambada10 Could you please:
• Assign this issue to me
• Add the hacktoberfest label
@VipulNerd commented on GitHub (Oct 2, 2025):
Hi @Lambada10 ,
I have fixed bug #175 and the changes have passed all automated build and test checks set up on GitHub.
Could you please assign the Hacktoberfest badge and close this issue?
Thanks!
@panicthescaredycat commented on GitHub (Oct 26, 2025):
Still getting that Spotify rate limit issue :(
@Spammfehler76 commented on GitHub (Nov 20, 2025):
Problem is Not solved. Still get the issue.
@panicthescaredycat commented on GitHub (Nov 21, 2025):
I honestly just found it easier to run a script on my PC that grabbed and embedded all the lyrics lol... and now when i download a song or album, i use this, since it'll do small number of songs without a problem.