mirror of
https://github.com/Lambada10/SongSync.git
synced 2026-04-25 22:55:54 +03:00
[GH-ISSUE #16] Batch Download immediately gets rate limited and aborts #10
Labels
No labels
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SongSync#10
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Enovale on GitHub (Aug 3, 2023).
Original GitHub issue: https://github.com/Lambada10/SongSync/issues/16
Describe the bug
When using the Batch Download feature, it downloads about 4 songs and then tells me it's reached Spotify's rate limit and stops. I don't see any way to adjust the speed at which it downloads the songs to avoid hitting the rate limit or let it retry.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
My lyrics get downloaded, and are retried if they hit the rate limit and back off the speed until there are no issues
Screenshots

Smartphone (please complete the following information):
Additional context
My library has 6k songs. This happened the very first time I tried downloading any lyrics.
@AkaneTan commented on GitHub (Aug 3, 2023):
@Enovale That's because songsync is using lambada10's public API and there's a limit. I would suggest wait for a day or compile your own package with your own API.
@Enovale commented on GitHub (Aug 3, 2023):
Sure, but if I set it up with my own API it's just going to eventually rate limit itself anyway (especially with 6k songs). Without any way to back off the API requests it won't be consistent.
@Lambada10 commented on GitHub (Aug 3, 2023):
@Enovale What do you mean by "back off the API requests"
Btw when API limit passes, you can filter songs to show no lyrics only and technically continue downloading
@Enovale commented on GitHub (Aug 6, 2023):
If the application is hitting the rate limit it needs to slow down future requests so that in the future it doesn't hit the limit, this is described in Spotify's API usage documentation iirc.
This would not have worked at all at the time this issue was created because I'm not going to download lyrics 4 songs at a time. However the new update that adds the Web Player API gets rate limited much much later (500 songs or so...?) so I will do this for the time being