mirror of
https://github.com/Rafiuth/Soggfy.git
synced 2026-04-25 15:16:00 +03:00
[GH-ISSUE #10] Multiple Album Artists #7
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Soggfy#7
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @markjoshwel on GitHub (Dec 14, 2021).
Original GitHub issue: https://github.com/Rafiuth/Soggfy/issues/10
As an example, the song Bruno Mars, Anderson .Paak, Silk Sonic - Leave The Door Open would be saved under
Bruno Mars\An Evening With Silk Sonic\2. Leave The Door Open.ogg.Is it intentional to treat the album artist as the first artist (Bruno Mars) rather than include all of the album artists? (Bruno Mars, Anderson .Paak, Silk Sonic)
I've noticed that this behaviour comes from SpotifyOggDumper/StateManager.cpp:389 where the name of the first artist in the
artistskey is taken.@markjoshwel commented on GitHub (Dec 14, 2021):
I'm trying to read your codebase (I come from a background of Python experience, C++ is still not too easy for me to read) and it appears that you do indeed merge all the artists together. (SpotifyOggDumper/StateManager:382)
However I think my issue comes from the bundled config.json in the releases, as the
"track_path_fmt"key is set to"%userprofile%/Music/Soggfy/{album_artist}/{album_name}/{track_num}. {track_name}.ogg")rather than"%userprofile%/Music/Soggfy/{artist_name}/{album_name}/{track_num}. {track_name}.ogg")(as per SpotifyOggDumper/StateManager.cpp:57). This means that I encounter my issue with only the first artist name being used asalbum_artistonly uses the first artist name rather thanartist_name.@Rafiuth commented on GitHub (Dec 14, 2021):
Yes, this is the default behavior, but you can change
{album_artist}to{artist}in the config.json file, to get all artists like in your example.The code at StateManager:57 is outdated, I changed the keys a while back and forgot to change this.
By the way, you can use any key listed in StateManager:387 in the config.json path variables.