mirror of
https://github.com/Rafiuth/Soggfy.git
synced 2026-04-26 07:35:54 +03:00
[GH-ISSUE #35] Allow Injector to search current directory for spotify. #33
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Soggfy#33
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SmilerRyan on GitHub (Jun 10, 2022).
Original GitHub issue: https://github.com/Rafiuth/Soggfy/issues/35
it would be quite nice if the injector could also search the current directory for a copy of Spotify to launch+Inject into.
Knowing that Spotify likes to force-update their software to
%AppData%, that could also save some update issues.Regarding settings (
%AppData%\Soggfyand%LocalAppData%\Spotify), I believe they're fine to stay there.This option would be great as it would allow users with a already-setup folder to simply copy + run.
The
spotifyfolder would be as it is in AppData, so it would launchSoggfy/spotify/Spotify.exe.I've just tried building the injector myself with the relative path, and it does work as expected.
Regarding adding both paths (
.\spotifyand%AppData%\Spotify), I wasn't sure how, sorry.@Rafiuth commented on GitHub (Jun 11, 2022):
I didn't know you could disable Spotify updates with a local copy like that. It would be interesting to have soggfy automatically install the latest supported version locally instead of using the version in AppData (it would effectively eliminate the need to patch hooks every couple updates).
It was intended for the injector to pickup Spotify.exe if it was on the same directory, but the code is wrong:
github.com/Rafiuth/Soggfy@729348dac5/Injector/Injector.cpp (L141-L144)It doesn't work because
exePathis empty when the if executes.I'll certainly look into this soon.
@Rafiuth commented on GitHub (Jul 21, 2022):
Implemented in https://github.com/Rafiuth/Soggfy/releases/tag/v2.3.0