mirror of
https://github.com/Rafiuth/Soggfy.git
synced 2026-04-25 23:25:58 +03:00
[GH-ISSUE #21] Cover art not downloaded properly #19
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Soggfy#19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ShowcaseKing on GitHub (Mar 5, 2022).
Original GitHub issue: https://github.com/Rafiuth/Soggfy/issues/21
Cover art which is automatically downloaded and embedded is only partially downloaded. Example:
OS: Windows 7
Spotify version: Spotify for Windows, 1.1.80.699
The latest release of the injector as of now.
@ShowcaseKing commented on GitHub (Mar 5, 2022):
I forgot to mention that because your powershell script for some reason threw an error that I manually downloaded ffmpeg so maybe that is the cause of the problem.
@maliayas commented on GitHub (Mar 6, 2022):
I have this, too. Same OS and version as the OP. Almost half of the tracks have this issue. Partial images gets embedded in ogg files. I don't have a clue as to why this happens.
@Rafiuth commented on GitHub (Mar 7, 2022):
Is this happening with
cover.jpgor just the embedded cover in the ogg file? I think it could be a ffmpeg issue or something in Spotify v1.80. I'd also appreciate if you guys can check if the previous version is also affected.@maliayas commented on GitHub (Mar 7, 2022):
Happening with
cover.jpgas well. Exact same partial image is embedded in the ogg. It doesn't seem specific to ogg format, selecting mp3 doesn't fix the issue.I don't think so but can it be a slow network issue? Does the software wait until the jpeg fully downloads? It being randomly occuring might mean that some error handling may be missing somewhere.
@ShowcaseKing commented on GitHub (Mar 7, 2022):
I just tested it on the older version and it works exactly the same.
@ShowcaseKing commented on GitHub (Mar 7, 2022):
By that I mean that it still downloads the images partially, in case I wasn't clear.
@Rafiuth commented on GitHub (Mar 8, 2022):
I managed to reproduce this issue on a Windows 7 VM, I will try to find the cause tomorrow.
@Rafiuth commented on GitHub (Mar 8, 2022):
This is apparently caused by uWebSockets v20.9.0, and weirdly enough, it only seems to affect Windows 7.
The bug was fixed in v20.10.0, but it's not available on vcpkg yet, so I just downgraded to v20.8.0.
Can you confirm this patch works?
@maliayas commented on GitHub (Mar 9, 2022):
Yes, it works! Thanks very much for the effort.
@ShowcaseKing commented on GitHub (Mar 9, 2022):
I too can confirm it works now so therefore I will close this issue. Thank you for taking the time to fix it.