[PR #87] [MERGED] Add Install.cmd and fix relative path issues in Install.ps1 #146

New issue

Closed

opened 2026-02-27 15:48:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:48:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rafiuth/Soggfy/pull/87
Author: @cubernetes
Created: 11/15/2023
Status: ✅ Merged
Merged: 11/16/2023
Merged by: @Rafiuth

Base: master ← Head: master

📝 Commits (3)

cfa772c Change all paths to absolute paths
34fee1b Add convenience script to launch Install.ps1 with correct execution policy.
7151e30 Update README.md

📊 Changes

3 files changed (+29 additions, -24 deletions)

View changed files

📝 README.md (+1 -1)
➕ SpotifyOggDumper/Data/Install.cmd (+1 -0)
📝 SpotifyOggDumper/Data/Install.ps1 (+27 -23)

📄 Description

Install.ps1 uses relative paths for all its file operations. However, in certain circumstances, this relative path points to C;\Windows\System32 (or whatever the system drive letter is). This is independent of the current working directory, so Set-Location -Path $PWD.Path does not affect that behaviour. The solution is to change all relative paths to absolute paths.

Also, many user complain that the script opens and exits immediately, which is due to the execution policy not being set. Setting the execution policy globally is a very bad idea, so you should never, ever run set-executionpolicy unrestricted. If at all you should run set-executionpolicy unrestricted -Scope process.
However, a more convenient way is to use a wrapper batch script to do that for you, as you can see in Install.cmd. This will start powershell with an execution policy "bypass" so it's only for the lifetime of the installation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rafiuth/Soggfy/pull/87 **Author:** [@cubernetes](https://github.com/cubernetes) **Created:** 11/15/2023 **Status:** ✅ Merged **Merged:** 11/16/2023 **Merged by:** [@Rafiuth](https://github.com/Rafiuth) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`cfa772c`](https://github.com/Rafiuth/Soggfy/commit/cfa772cf44a5f34d97a4a9aa3352e05ec38b3ab2) Change all paths to absolute paths - [`34fee1b`](https://github.com/Rafiuth/Soggfy/commit/34fee1ba56881a0ea30c7b0967456c5b3ee3b89c) Add convenience script to launch Install.ps1 with correct execution policy. - [`7151e30`](https://github.com/Rafiuth/Soggfy/commit/7151e30d9df4e80022710286a22dc76cfbc02636) Update README.md ### 📊 Changes **3 files changed** (+29 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) ➕ `SpotifyOggDumper/Data/Install.cmd` (+1 -0) 📝 `SpotifyOggDumper/Data/Install.ps1` (+27 -23) </details> ### 📄 Description Install.ps1 uses relative paths for all its file operations. However, in certain circumstances, this relative path points to C;\Windows\System32 (or whatever the system drive letter is). This is independent of the current working directory, so `Set-Location -Path $PWD.Path` does not affect that behaviour. The solution is to change all relative paths to absolute paths. Also, many user complain that the script opens and exits immediately, which is due to the execution policy not being set. Setting the execution policy globally is a very bad idea, so you should never, ever run `set-executionpolicy unrestricted`. If at all you should run `set-executionpolicy unrestricted -Scope process`. However, a more convenient way is to use a wrapper batch script to do that for you, as you can see in Install.cmd. This will start powershell with an execution policy "bypass" so it's only for the lifetime of the installation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 15:48:28 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/Soggfy#146

No description provided.

Rows
Columns