mirror of
https://github.com/SignTools/SignTools.git
synced 2026-04-27 10:55:49 +03:00
[GH-ISSUE #412] Ability to specify host for cloudflared #100
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SignTools#100
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BluDood on GitHub (Mar 26, 2024).
Original GitHub issue: https://github.com/SignTools/SignTools/issues/412
!! Please fill in this template, DO NOT ignore or delete it. !!
I tried basic troubleshooting first
Describe the bug
I'm trying to run SignTools and a CloudFlare tunnel inside docker compose, but SignTools is hardcoded to only look for cloudflared on localhost. Therefore it would be very useful to be able to specify the host used for connecting to the cloudflared metrics endpoint.
To reproduce
In my case, I wrote a simple compose project as follows:
By opening the generated tunnel URL, I can access the web interface just fine. However, this does not work once I try to sign the application as it has to send data back to the public endpoint. I could manually specify the URL inside signer-cfg.yml, but since the functionality is already built-in it would be nice to have an extra option to specify a custom host for cloudflared. For example:
SignTools -cloudflared-host cloudflared -cloudflared-port 51881or simply:
SignTools -cloudflared-host cloudflared:51881I imagine it wouldn't be too hard to add some changes here (for the CLI parameter) and here (to change the host from localhost to whatever is specified). I don't know Go too well, but if help is needed I can see what I can do.
Expected behavior
Being able to specify the full host for the cloudflared endpoint / host, and therefore making it easier to run SignTools in a Docker Compose project.
System configuration
@BluDood commented on GitHub (Mar 26, 2024):
Decided to try and fix this myself, I've made the pull request #413 with the suggested changes and tested that it works fine.
@ViRb3 commented on GitHub (Apr 14, 2024):
Merged PR, will release in v3.0.3 shortly. Thanks!