[PR #33] [CLOSED] Develop #91

New issue

Closed

opened 2026-02-27 20:31:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:31:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/pull/33
Author: @GruberMarkus
Created: 3/17/2022
Status: ❌ Closed

Base: main ← Head: develop

📝 Commits (10+)

cedc007 style: "open-source" insted of "open source" where possible
554c0dd docs: typos
d78e4f9 chore: Validate parameter SimulateMailboxes
f1655ef chore: Validate format of parameter SimulateUser
d057dbe fix: Switch to GraphOnly=$true when user's on-prem AD forest root domain can't be contacted.
46b220f fix: correctly handle objectsid and sidhistory from Graph
3aa5529 fix: more objectsid and sidhistory attribute checks
0da986b fix: Use another Windows API to get DN of logged in user
29aa9cd doc: prepare for v2.5.2 release
5bfb3c7 fix: Use another Windows API that does not require read access to CN=Computers

📊 Changes

7 files changed (+137 additions, -99 deletions)

View changed files

📝 .github/workflows/build, draft release.yml (+1 -1)
📝 docs/CHANGELOG.md (+7 -1)
📝 docs/CODE_OF_CONDUCT.md (+1 -1)
📝 docs/CONTRIBUTING.md (+3 -3)
📝 docs/Implementation approach.md (+8 -8)
📝 docs/README.md (+5 -5)
📝 src/Set-OutlookSignatures.ps1 (+112 -80)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/pull/33 **Author:** [@GruberMarkus](https://github.com/GruberMarkus) **Created:** 3/17/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`cedc007`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/cedc007f490702ebbdf0e0a8d1e13896cda3f83c) style: "open-source" insted of "open source" where possible - [`554c0dd`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/554c0dd266a37c382e53d822c63a59b562387d24) docs: typos - [`d78e4f9`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/d78e4f9c7eafc307423d4270a10593bc893592b7) chore: Validate parameter SimulateMailboxes - [`f1655ef`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/f1655ef99eac2b8132909120e3f3a5f4a562fcfe) chore: Validate format of parameter SimulateUser - [`d057dbe`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/d057dbe2ee710dacd0ac7a0df75459f06843c415) fix: Switch to GraphOnly=$true when user's on-prem AD forest root domain can't be contacted. - [`46b220f`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/46b220f8527a6447612c982e57b29353a1d9b83e) fix: correctly handle objectsid and sidhistory from Graph - [`3aa5529`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/3aa5529a6f9937d317520c78a3a00f1d7c998fdf) fix: more objectsid and sidhistory attribute checks - [`0da986b`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/0da986b46bc21c47247e0964eeb0963580430d65) fix: Use another Windows API to get DN of logged in user - [`29aa9cd`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/29aa9cd898fdfce60d3d992c2d90da959e4fefe8) doc: prepare for v2.5.2 release - [`5bfb3c7`](https://github.com/Set-OutlookSignatures/Set-OutlookSignatures/commit/5bfb3c7692c30f7b7d75e3d61b2f14b26d927319) fix: Use another Windows API that does not require read access to CN=Computers ### 📊 Changes **7 files changed** (+137 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build, draft release.yml` (+1 -1) 📝 `docs/CHANGELOG.md` (+7 -1) 📝 `docs/CODE_OF_CONDUCT.md` (+1 -1) 📝 `docs/CONTRIBUTING.md` (+3 -3) 📝 `docs/Implementation approach.md` (+8 -8) 📝 `docs/README.md` (+5 -5) 📝 `src/Set-OutlookSignatures.ps1` (+112 -80) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>