mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 15:15:51 +03:00
[GH-ISSUE #110] Open a project or any image make app to crash #98
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#98
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Fred-Vatin on GitHub (Mar 19, 2017).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/110
I juts tested the app v2.6 in Windows 10 pro x64 (french) with last updates.
I saved a project and close the app. Later I open the project and the app crash.
Here is the log.
Here is the project.
So unzip the project and try to open one of its image. Crash again. I don't seem to be able to open anything without crashing the app.
Hope you can fix it.
edit: I fix it. I have to go to settings and delete the temp folder before opening some media. But it is still a bug.
@NickeManarin commented on GitHub (Mar 19, 2017):
Hi, I could not reproduce this bug with v2.6 but I believe that it got fixed because of a previous issue related to opening/loading projects or images.
By the looks of it, this code throws the exception:
Specially because the first parameter was null (not set), but I don't know why exactly.
ScreenToGif 2.X Preview.zip
Could you download this attachment and test if you notice the same behavior?
@Fred-Vatin commented on GitHub (Mar 20, 2017):
Thanks. It seems I can not reproduce this bug with v2.6 again. Don't know what happened then. Maybe because I changed the default user settings location to app folder during the session I saved as the project. Next I quitted the app and later the crash occurred when I tried to open that project.
It's just an idea. All seem fine now. Your tool is awesome and well designed. Good work !
I think you can close the issue now.
@NickeManarin commented on GitHub (Mar 21, 2017):
Oh, that explains it. :)
When you delete a settings file, the current instance of the app keeps alive your latest settings until you close the app.
After opening the app again with the settings erased, the property
TemporaryFolder(that holds the location of the recording files) was empty/null.The bug here is that the Editor wasn't using the default value for the
TemporaryFolderlike the Recorder does when that property is empty.To import a project or record something that values is obligatory, if there's no value for that, the app crashes. But now this bug is fixed.
Thank you for your feedback and your kind words. :D