mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[GH-ISSUE #1279] [Bug] The coding progress rate exceeds 100% #940
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#940
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @inoyakaigor on GitHub (Feb 7, 2024).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1279
Originally assigned to: @NickeManarin on GitHub.
Describe the bug
Often percenatge of encoding process exceed 100%
To Reproduce

Steps to reproduce the behavior:
Just tryed to save a video with these config
Expected behavior
Progress must not exceed 100%
Screenshots

Link to video (Can't attach because it exceed GH file size limit)
But there is most important frame:
Desktop (please complete the following information):
Additional context
The video was shot when I set the latest version of ffmpeg 6.1.1 but I've met this bug with in box ffmpeg 4
@pawlos commented on GitHub (Mar 10, 2024):
Yeah, there's an issue when the ffmpeg encoder produces duplicated frames. The returned frame count number is such case can be greater then one that was passed. We should consider reducing the frame number by the duplicated ones. I'll create a PR to fix this.
@pawlos commented on GitHub (Mar 10, 2024):
Ok, this is a bit more interesting that initially anticipated.
One of the output lines from ffmpeg:
So it's not just a matter of removing the dup's as that would produce problems on the other end. Values below 0%. Investigating.