starred/ScreenToGif
1
0
Fork 0
mirror of https://github.com/NickeManarin/ScreenToGif.git synced 2026-04-25 23:25:52 +03:00
Code Issues 1.1k Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #1246] [Bug] Editor - Statistics - duration unit wrong #921

New issue
Open
opened 2026-02-26 09:33:01 +03:00 by kerem · 3 comments
kerem commented 2026-02-26 09:33:01 +03:00
Owner
Copy link

Originally created by @fireattack on GitHub (Nov 5, 2023).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1246

Originally assigned to: @NickeManarin on GitHub.

Describe the bug
The durations are in seconds (s), not "m".

To Reproduce
Steps to reproduce the behavior:

  1. Go to Editor -> Statistics
  2. Check toolbar

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

bug

Desktop (please complete the following information):

  • OS: Windows 10
  • Version 2.39
Originally created by @fireattack on GitHub (Nov 5, 2023). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1246 Originally assigned to: @NickeManarin on GitHub. **Describe the bug** The durations are in seconds (s), not "m". **To Reproduce** Steps to reproduce the behavior: 1. Go to Editor -> Statistics 2. Check toolbar **Expected behavior** A clear and concise description of what you expected to happen. **Screenshots** ![bug](https://github.com/NickeManarin/ScreenToGif/assets/4130991/c1e5828c-0d87-4046-9f15-35543d5bcfc6) **Desktop (please complete the following information):** - OS: Windows 10 - Version 2.39
kerem commented 2026-02-26 09:33:02 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Nov 7, 2023):

It's read as 0 minutes, 0 seconds, 50 miliseconds, and since I'm showing the minutes part, the label it's shown as "m".

I can change to reduce the minimum level to seconds (when less than 1 minute), then it will display as: 00.050 s

<!-- gh-comment-id:1799201159 --> @NickeManarin commented on GitHub (Nov 7, 2023): It's read as 0 minutes, 0 seconds, 50 miliseconds, and since I'm showing the minutes part, the label it's shown as "m". I can change to reduce the minimum level to seconds (when less than 1 minute), then it will display as: 00.050 s
kerem commented 2026-02-26 09:33:02 +03:00
Author
Owner
Copy link

@fireattack commented on GitHub (Nov 10, 2023):

Thanks for explanation!

I'd argue even if it's more than 1 minute, say, 2m5s, a notation of "02:05.000 m" is still weird, if not wrong (like you won't write 2h10m5s as "02:10:05.000 h").

Since it's just a standard timestamp format, and the inclusion of milliseconds makes it not ambiguous, maybe we can just remove the unit?

<!-- gh-comment-id:1805272584 --> @fireattack commented on GitHub (Nov 10, 2023): Thanks for explanation! I'd argue even if it's more than 1 minute, say, 2m5s, a notation of "02:05.000 m" is still weird, if not wrong (like you won't write 2h10m5s as "02:10:05.000 h"). Since it's just a standard timestamp format, and the inclusion of milliseconds makes it not ambiguous, maybe we can just remove the unit?
kerem commented 2026-02-26 09:33:02 +03:00
Author
Owner
Copy link

@pawlos commented on GitHub (Nov 10, 2023):

Tbh, when I briefly looked at this in the code, to me it should also be w/o any unit

<!-- gh-comment-id:1806292514 --> @pawlos commented on GitHub (Nov 10, 2023): Tbh, when I briefly looked at this in the code, to me it should also be w/o any unit
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dev
v2.40
2.43.1
2.43
2.42.1
2.42
2.41.5
2.41.4
2.41.3
2.41.2
2.41.1
2.41
2.40.1
2.40
2.39
2.38.1
2.38
2.37.2
2.37.1
2.37
2.36
2.35.4
2.35.3
2.35.2
2.35.1
2.35
2.34.1
2.34
2.33.1
2.33
2.32.1
2.32
2.31
2.30.1
2.30
2.29.1
2.29
2.28.2
2.28.1
2.28
2.27.3
2.27.2
2.27.1
2.27
2.26.1
2.26
2.25
2.24.2
2.24.1
2.24
2.23.2
2.23.1
2.23
2.22.1
2.22
2.21.2
2.21.1
2.21
2.20.4
2.20.3
2.20.2
2.20.1
2.20
2.19.3
2.19.2
2.19.1
2.19
2.18
2.17.1
2.17
2.16
2.15.2
2.15.1
2.15
2.14.1
2.14
2.13.3
2.13.2
2.13.1
2.13
2.12.1
2.12
2.11
2.10
2.9
2.8.1
2.8
2.7.3
2.7.2
2.7.1
2.7
2.6
2.5
2.4
2.3.2
2.3.1
2.3
2.2
2.1
Labels
Clear labels   
copy cats

   
duplicated

   
future feature

   
pull-request

Mirrored from GitHub Pull Request

  
⬜ Accepted

   
⬜ Completed

   
⬜ Help Wanted 💪

   
⬜ In Progress

   
⬜ Missing Details

   
⬜ Pending

   
⬜ Waiting For Answer ⏳

   
🆕 feature preview

   
🔷 Bug 🐛

   
🔷 Out Of Scope

   
🔷 Out Of Scope

   
🔷 Question

   
🔷Enhancement

   
🔷Enhancement

   
🔷Invalid / External

   
🔷Knowledge Base

   
🔷Won't Fix

   
🕑 High

   
🕑 High

   
🕑 High

   
🕕 Medium

   
🕙 Low

   
🕛 Critical
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#921
No description provided.