mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-26 07:35:54 +03:00
[GH-ISSUE #1214] [Bug] newest gifski does not work with screengif #903
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#903
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Herr-Sepp on GitHub (Jul 14, 2023).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1214
Originally assigned to: @NickeManarin on GitHub.
Describe the bug
Using the newest gifski dll creates broken gif files
To Reproduce
Steps to reproduce the behavior:
Expected behavior
the .gif works
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
@cherinyy commented on GitHub (Aug 31, 2023):
I noticed that they provide a shared library in 1.5.0, but ScreenToGif doesn't work with it. This means that ScreenToGif does not use the officially built Gifski shared library.
This issue should probably be closed and a feature request issue raised to allow the use of the official gifski shared library.
@NickeManarin commented on GitHub (Aug 31, 2023):
I added support for it with v3 of the app (still in development), so I just nee to port back the changes to v2.
@NickeManarin commented on GitHub (Oct 1, 2023):
I tested with that version and it works normally btw.
@byzod commented on GitHub (Oct 8, 2023):
How? What version are you talking about? I downloaded both https://gif.ski/gifski-1.11.0.zip and https://gif.ski/gifski-1.5.0.zip mentioned above but none of them working
@ghost commented on GitHub (Apr 4, 2024):
It seems that the rust code rewrite made latest gifski DLL libraries (taken from the win/developer folder of the tar.gz archive) work again with S2G, albeit not properly:
1.14.1 and 1.14.4 have both problems with GIFs being sped-up (as if the new encoder build didn't respect frame delays) and an unexpectionally long pause at the end of the gif playback before it starts looping again.
BTW: Does the "loop forever" option even work? It feels like the output gif still loops in my browser & irfanview when that option is disabled. Tested with the bundled-as-plugin DLL and with 1.14.4
An 1.14.1-specific issue is that it has visual glitches in the exported gif, but not sure if that's just gifski-specific. Regardless, 1.14.4 doesn't exhibit this problem.
Not sure of any other issues existing that haven't exhibited in the bundled-as-plugin library from 2020-09.
I attached the project file that I used to test gifski onto.
Imported the gifski-1.14.4 output gif to a new project - all but the last frames are set to a 20ms delay, with the last frame being 16090 ms. Imported the output gif that was exported with the default gifski version (I believe it was 1.2.0, yeah?) to a new project, and the timings were intact.
Surprised to see the bundled gifski build working with variable frame delays, as seeing gifski's issue tracker - it's not really supported.
test_project.stg.zip
@Putarku commented on GitHub (Dec 11, 2024):
By the end of 2024, I revisited this issue, but unfortunately, it remains unresolved. Gifski has now been updated to version 1.32.0, yet when used in conjunction with S2G, it still produces erroneous GIF outputs.
Currently, S2G can only utilize the outdated version that is downloaded by default, which has poor compression quality, resulting in excessive noise and color blocks. This is significantly inferior to the newer versions of Gifski available today.
Therefore, I hope the author can address this issue. Thank you : )
@NickeManarin commented on GitHub (Dec 15, 2024):
The encoder was working, but the version detection check was not (gifski DLL has no version number, so it's a guess which version it is).
Next release should have the fix for this.