mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[GH-ISSUE #937] [Bug] Can't set Ctrl+Alt+-/= as shortcuts #723
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#723
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @wenfangdu on GitHub (Jul 11, 2021).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/937
Originally assigned to: @pawlos on GitHub.
I was trying to set
Ctrl+Alt+-forDiscardandCtrl+Alt+=forStop, but couldn't set them successfully.For what it's worth,
Ctrl+Alt+0can be set.@pawlos commented on GitHub (Jul 20, 2021):
@NickeManarin I can see in the code that those are not allowed. Any particular reason for that? Changing the code to allow those seems to be working fine
@pawlos commented on GitHub (Jul 21, 2021):
Not sure why I've posted with Shift 🤦♂️, but it works with Alt too.
@NickeManarin commented on GitHub (Jul 21, 2021):
@pawlos The recorder uses a different method for the detection of key presses.
I don't remember exactly why I set to prevent users from setting some keys, but it had something to do with the key hook.
@pawlos commented on GitHub (Jul 23, 2021):
@NickeManarin I guess it might be due to the fact that above the current cut (key code 114), there's some buttons that would make sense to exclude like shifts, alts or scrlock (so the allowed key combination could be alt + shift + shift :D). Since the cut was deliberate do you consider this as a bug & to be fixed? Or is it ok as designed to exclude some chars.
@NickeManarin commented on GitHub (Jul 24, 2021):
@pawlos There are some keys which could be allowed but were cut by mistake.
@pawlos commented on GitHub (Jul 26, 2021):
I've decided to do a change and add those between 140 and 154. The ones from 157 marked as //? seems like a bit of controling characters than the actual ones.
@NickeManarin commented on GitHub (Aug 8, 2021):
Interesting, Ctrl + Shift + 0 (zero) may not work for most people.
https://github.com/Microsoft/vscode/issues/2585
@pawlos commented on GitHub (Aug 9, 2021):
@NickeManarin thx for the link.