starred/ScreenToGif
1
0
Fork 0
mirror of https://github.com/NickeManarin/ScreenToGif.git synced 2026-04-25 07:05:54 +03:00
Code Issues 1.1k Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #930] [Bug] Focus dialog after using a shortcut to stop recording #716

New issue
Open
opened 2026-02-26 09:32:24 +03:00 by kerem · 8 comments
kerem commented 2026-02-26 09:32:24 +03:00
Owner
Copy link

Originally created by @wenfangdu on GitHub (Jul 4, 2021).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/930

Currently, when using a shortcut to stop recording, the "Discard Project" dialog won't be focused, although the "No" button seems to be focused, in fact, it's not, therefore using arrow keys to switch option is not available:

image

Meanwhile, clicking the "stop recording" button will focus the "Discard Project" dialog:

image

For accessibility, it'd be great to unify this behavior and to generalize this issue, all dialogs might be checked.

Originally created by @wenfangdu on GitHub (Jul 4, 2021). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/930 Currently, when using a shortcut to stop recording, the "Discard Project" dialog won't be focused, although the "No" button seems to be focused, in fact, it's not, therefore using arrow keys to switch option is not available: ![image](https://user-images.githubusercontent.com/28700378/124371056-b2f9c400-dcb0-11eb-8526-5ca248ea86f7.png) Meanwhile, _clicking_ the "stop recording" button will focus the "Discard Project" dialog: ![image](https://user-images.githubusercontent.com/28700378/124371368-b93d6f80-dcb3-11eb-8706-01f41bf78303.png) For accessibility, it'd be great to unify this behavior and to generalize this issue, all dialogs might be checked.
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Jul 4, 2021):

Thanks.

Looks like something is stealing the focus when the dialog is opening (or perhaps the dialog needs a force focus to activate properly).

<!-- gh-comment-id:873645895 --> @NickeManarin commented on GitHub (Jul 4, 2021): Thanks. Looks like something is stealing the focus when the dialog is opening (or perhaps the dialog needs a force focus to activate properly).
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@pawlos commented on GitHub (Jul 7, 2021):

@NickeManarin If you haven't started working on this, I can have a look at this one.

<!-- gh-comment-id:875259037 --> @pawlos commented on GitHub (Jul 7, 2021): @NickeManarin If you haven't started working on this, I can have a look at this one.
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@pawlos commented on GitHub (Jul 9, 2021):

It looks like the issue is that the Window is shown but not Activated. When done the same by mouse click - activates it. Did some initial testing and calling Activate not always works. What works is showing the editor before showing the dialog. I'll test this solution more to see if there aren't any unwanted behavior.

<!-- gh-comment-id:877431508 --> @pawlos commented on GitHub (Jul 9, 2021): It looks like the issue is that the Window is shown but not Activated. When done the same by mouse click - activates it. Did some initial testing and calling Activate not always works. What works is showing the editor before showing the dialog. I'll test this solution more to see if there aren't any unwanted behavior.
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@wenfangdu commented on GitHub (Jul 26, 2021):

@NickeManarin @pawlos Just tried v2.33.1, still reproducible, could you please consider reopening this issue?

<!-- gh-comment-id:886724230 --> @wenfangdu commented on GitHub (Jul 26, 2021): @NickeManarin @pawlos Just tried v2.33.1, still reproducible, could you please consider reopening this issue?
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@pawlos commented on GitHub (Jul 26, 2021):

I can't but @NickeManarin can reopen.

<!-- gh-comment-id:886800248 --> @pawlos commented on GitHub (Jul 26, 2021): I can't but @NickeManarin can reopen.
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Jul 26, 2021):

It's working normally for me.
Pressing F8 to stop the recording still gives the focus to the dialog that asks about discarding the previous project.

Can you record your screen to show to us?
Or can you give us a step-by-step guide on how to get the same issue?

<!-- gh-comment-id:886950001 --> @NickeManarin commented on GitHub (Jul 26, 2021): It's working normally for me. Pressing F8 to stop the recording still gives the focus to the dialog that asks about discarding the previous project. Can you record your screen to show to us? Or can you give us a step-by-step guide on how to get the same issue?
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@wenfangdu commented on GitHub (Jul 29, 2021):

@NickeManarin @pawlos

Repro steps:

  1. Click "Record".
  2. Click the area being recorded (important, otherwise will return focus to the dialog).
  3. Hit F8.
<!-- gh-comment-id:889156580 --> @wenfangdu commented on GitHub (Jul 29, 2021): @NickeManarin @pawlos Repro steps: 1. Click "Record". 2. Click the area being recorded (important, otherwise will return focus to the dialog). 3. Hit `F8`.
kerem commented 2026-02-26 09:32:24 +03:00
Author
Owner
Copy link

@pawlos commented on GitHub (Jul 29, 2021):

@wenfangdu thx for the steps. I'll get back to this issue.

<!-- gh-comment-id:889473719 --> @pawlos commented on GitHub (Jul 29, 2021): @wenfangdu thx for the steps. I'll get back to this issue.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dev
v2.40
2.43.1
2.43
2.42.1
2.42
2.41.5
2.41.4
2.41.3
2.41.2
2.41.1
2.41
2.40.1
2.40
2.39
2.38.1
2.38
2.37.2
2.37.1
2.37
2.36
2.35.4
2.35.3
2.35.2
2.35.1
2.35
2.34.1
2.34
2.33.1
2.33
2.32.1
2.32
2.31
2.30.1
2.30
2.29.1
2.29
2.28.2
2.28.1
2.28
2.27.3
2.27.2
2.27.1
2.27
2.26.1
2.26
2.25
2.24.2
2.24.1
2.24
2.23.2
2.23.1
2.23
2.22.1
2.22
2.21.2
2.21.1
2.21
2.20.4
2.20.3
2.20.2
2.20.1
2.20
2.19.3
2.19.2
2.19.1
2.19
2.18
2.17.1
2.17
2.16
2.15.2
2.15.1
2.15
2.14.1
2.14
2.13.3
2.13.2
2.13.1
2.13
2.12.1
2.12
2.11
2.10
2.9
2.8.1
2.8
2.7.3
2.7.2
2.7.1
2.7
2.6
2.5
2.4
2.3.2
2.3.1
2.3
2.2
2.1
Labels
Clear labels   
copy cats

   
duplicated

   
future feature

   
pull-request

Mirrored from GitHub Pull Request

  
⬜ Accepted

   
⬜ Completed

   
⬜ Help Wanted 💪

   
⬜ In Progress

   
⬜ Missing Details

   
⬜ Pending

   
⬜ Waiting For Answer ⏳

   
🆕 feature preview

   
🔷 Bug 🐛

   
🔷 Out Of Scope

   
🔷 Out Of Scope

   
🔷 Question

   
🔷Enhancement

   
🔷Enhancement

   
🔷Invalid / External

   
🔷Knowledge Base

   
🔷Won't Fix

   
🕑 High

   
🕑 High

   
🕑 High

   
🕕 Medium

   
🕙 Low

   
🕛 Critical
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#716
No description provided.