mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 15:15:51 +03:00
[GH-ISSUE #910] Two questions about dark mode #703
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#703
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DeepChirp on GitHub (Jun 4, 2021).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/910
Originally assigned to: @pawlos on GitHub.
Hello!
1.The title bar in dark mode is not black, so it is not very coordinated.
2.The color scheme of the editor does not seem to follow the system.
Can u fix it in the next version? Thanks!
@NickeManarin commented on GitHub (Jun 4, 2021):
That's up to your OS. Looks like you are not setting the title bar to follow any accent color.
That's a separated color scheme. It was left like that so you can pick any color not being bound to the current theme. Another option called "Follow system" could be created for this.
@pawlos commented on GitHub (Jun 4, 2021):
When doing the dark theme, I wasn't sure about the editor as the colors there are hand picked (as far as I could see) and not based on themes but @NickeManarin please assign me to the ticket, I will add "Follow the system" in the editor too".
@DeepChirp commented on GitHub (Jun 4, 2021):
Hello!
1.Other software such as Explorer can change the color of the title bar.
@pawlos commented on GitHub (Jun 5, 2021):
@shenzhiming88 I'm working on the "Follow the system" for the grid and as for explorer, it might be doing full custom rendering of the Window but it strange it doesn't respect user settings. If you want ScreenToGif's title bar follow the color just set the option in Windows as @NickeManarin suggested
@DeepChirp commented on GitHub (Jun 5, 2021):
@pawlos
Hello!
There are many third-party applications that customize the title bar, such as IDM and VMWare. But I don't know how they are implemented.
@NickeManarin commented on GitHub (Jun 5, 2021):
That often requires a custom window, which in turn as a tradeoff reduces the performance.
ScreenToGif has custom windows (the recorders).
@Geeyun-JY3 commented on GitHub (Jun 21, 2021):
So if I am not setting the title bar to follow any accent color, it would be always white? Shouldn't it follow the OS color theme (default app mode)? Chrome ’s title bar would be dark when default app mode is dark and users not setting the title bar to follow any accent color.
@Geeyun-JY3 commented on GitHub (Jun 29, 2021):
@NickeManarin
@NickeManarin commented on GitHub (Jun 29, 2021):
@NickeManarin commented on GitHub (Jun 29, 2021):
@NickeManarin commented on GitHub (Jun 29, 2021):
Browsers such as Chrome rewrite the title bar (because they add support for tabs and other elements). ScreenToGif doesn't do that, so it follows the default settings.
@Geeyun-JY3 commented on GitHub (Jun 29, 2021):
So is there any consideration that ScreenToGif doesn't do that? Or actually https://github.com/NickeManarin/ScreenToGif/issues/910#issuecomment-855304303 has already explained it.(TBH I don't understand what https://github.com/NickeManarin/ScreenToGif/issues/910#issuecomment-855304303 means🤦♂️)
@NickeManarin commented on GitHub (Jun 29, 2021):
I found one way to manually set the title bar color, without having to deal with a manual assembly of the title bar.
It is a hack and it needs to be applied for each window, so it may not be a good solution.
@Geeyun-JY3 commented on GitHub (Jul 1, 2021):
Fine.