mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[GH-ISSUE #835] Version 2.28.1 killed all the settings and didn't want to save them anymore #656
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#656
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @wvxwxvw on GitHub (Apr 21, 2021).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/835
By the way, you need to add the option to backup the program settings.
@NickeManarin commented on GitHub (Apr 21, 2021):
Do you mean the export settings or the whole app's settings?
@wvxwxvw commented on GitHub (Apr 21, 2021):
Applications. To avoid such misunderstandings.
@NickeManarin commented on GitHub (Apr 21, 2021):
I just tested with a previous version settings file, the app loaded the settings (except the export settings, which are not compatible with the new release) and it was able to save it again when closing the app.
Can you check if there's any log file that was created?
@wvxwxvw commented on GitHub (Apr 21, 2021):
There are
21_04_21____ch19-17__MyDoc.zip
21_04_21____ch20-18__port.zip
I initially deleted this version and returned 2.28.0, there are no problems with it. But now, during the test, it turned out that with the new settings file created in 2.28.0, everything seems to be fine, so far.
@NickeManarin commented on GitHub (Apr 21, 2021):
So, you were using v2.27.3, downloaded and used v2.28 and when starting to use v2.28.1 the settings were lost?
@NickeManarin commented on GitHub (Apr 21, 2021):
I changed the way how the settings are parsed, by adding some other validation steps before trying to parse.
I also fixed the second issue (about not being able to save the settings).
One or more settings were set to null and the settings exporter wis not able to determine the type of the property when saving.
Thank you for the feedback!
@wvxwxvw commented on GitHub (Apr 22, 2021):
Yes. Moreover, one or more times 2.28.1 loaded the settings. More precisely, I do not remember, probably it is in the logs.