mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-26 07:35:54 +03:00
[GH-ISSUE #741] add scoop as installation method #598
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#598
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @shafschwd on GitHub (Oct 10, 2020).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/741
add scoop as installation method on website and on readme.md
https://github.com/lukesampson/scoop-extras/blob/master/bucket/screentogif.json
Scoop is a command-line installer for Windows
@Polisson commented on GitHub (Mar 15, 2022):
+1 to idea, but...
besides placing website/readme.md, this method needs more testing because there is a little issue with installing of (and I'll describe it here as the title best fit):
ScreenToGif doesn't seem to save user configuration between its launching.
Scoop makes two things:
~\scoop\apps\screentogif\currentto actual app version folder (as of writing 2.36), that's OK;~\scoop\apps\screentogif\current\Settings.xamlis hardlinked to~\scoop\persist\screentogif\Settings.xamlthat is a culprit!As a workaround to restore saving of settings: break this hardlink (specifically: replace with symlink to persistent dir).
I am writing a parallel issue on extras bucket github repo issues. Here for anybody wanting to instant solution.
@rashil2000 commented on GitHub (Mar 15, 2022):
I'm not able to reproduce the above issue. My settings are saved as they should. Also, in both the the cases, the link is a hardlink. Scoop does not create symlinks.
@Polisson commented on GitHub (Mar 16, 2022):
OK. In my case, two discrete machines have the same behavior.
I've just made another test and have a suspicion:
After standard installation by scoop, the file
Settings.xamlhas 0 bytes (empty, of course).But when this file is not existing, ScreenToGif creates one on first launch with such content:
<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"></ResourceDictionary>So existing an empty file (with no structure) prevents from making new default file.
@rashil2000 commented on GitHub (Mar 16, 2022):
Is the default settings file available somewhere in this repo? We can use it instead of creating a new (blank) settings file.
@Polisson commented on GitHub (Mar 16, 2022):
Nope, installation scoop just downloads portable edition of app, then extracts it and creates it's file structure (links files and folders in few places).
I'm a newbie in scoop configs, but maybe there is possibility to fill up file with correct/required content, right after creation.
@rashil2000 commented on GitHub (Mar 16, 2022):
Yep, that's what I'm saying
@Polisson commented on GitHub (Mar 16, 2022):
You asked if there is a file, but I'm saying there is no such file. So I came up with ScreenToGif ability to fill an empty file with correct structure:
@rashil2000 commented on GitHub (Mar 16, 2022):
I'm not sure I follow, how will you ask Screentogif to create the file while it's installing?
@Polisson commented on GitHub (Mar 16, 2022):
OK, so the simplest way of my understanding...
Two alternative solutions I'm imaging:
<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"></ResourceDictionary>. Here installation is finished@rashil2000 commented on GitHub (Mar 16, 2022):
The first method sounds elegant. Can you make a PR for it?