mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[GH-ISSUE #601] App crashes on load trying to access AccountDomainSid #497
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#497
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @robeving on GitHub (Feb 26, 2020).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/601
github.com/NickeManarin/ScreenToGif@55b6ad12bd/ScreenToGif/App.xaml.cs (L81)So it looks like you check user for null but not AccountDomainSid. AccountDomainSid can actually be null as well which causes an exception when you run the app.
Fix is to change to user.Value.ToString()
@NickeManarin commented on GitHub (Feb 26, 2020):
Ok, I'm going to replace with:
var mutexName = (user?.Value ?? Environment.UserName) + "_" + location;Thanks.
@NickeManarin commented on GitHub (Feb 26, 2020):
Fixed. A new version will be released shortly.
v2.21.1