[GH-ISSUE #1093] [Enhancement] Refactoring user settings parsing #3040

New issue

Closed

opened 2026-03-01 19:06:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 19:06:11 +03:00

Owner

Originally created by @koszeggy on GitHub (Mar 20, 2022).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1093

Originally assigned to: @koszeggy on GitHub.

Parsing user settings is a pain now as whenever a new enum or nullable type is used it must be handled manually.

A need for refactoring is also indicated in the source code:

//Do you know any other way to achieve this? Contact me via Github.

As I mentioned I already addressed the issue during the development of #1069 because it affected my changes as well. But since the solution was dependent on #1069 (because I created a sub-branch from its feature branch and because it uses one of the libraries that was added for #1069) I waited with a new pull request until #1069 was merged.

Git was a bit confused though when I tried to merge the refactoring branch to dev because all of the changes of #1069 appeared again for review (even though these changes are merged now into dev), so in the end I canceled the pull request. I can try it again during the next week by creating a new branch directly from dev and reintroducing the changes (only UserSettings.cs is affected) so it will be clean enough for git, too.

Until then, feel free to assign the issue to me.

Originally created by @koszeggy on GitHub (Mar 20, 2022). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1093 Originally assigned to: @koszeggy on GitHub. Parsing user settings is a pain now as whenever a new enum or nullable type is used it must be handled manually. A need for refactoring is also [indicated](https://github.com/NickeManarin/ScreenToGif/blob/84a0a739163ab61bc2ff7ea7669fdc3549e5ca38/ScreenToGif.Util/Settings/UserSettings.cs#L194) in the source code: //Do you know any other way to achieve this? Contact me via Github. As I [mentioned](https://github.com/NickeManarin/ScreenToGif/issues/1069#issuecomment-1034874240) I already addressed the issue during the development of #1069 because it affected my changes as well. But since the solution was dependent on #1069 (because I created a sub-branch from its feature branch and because it uses one of the libraries that was added for #1069) I waited with a new pull request until #1069 was merged. Git was a bit confused though when I tried to merge the [refactoring branch](https://github.com/koszeggy/ScreenToGif/tree/UserSettingsRefactoring) to `dev` because all of the changes of #1069 appeared again for review (even though these changes are merged now into `dev`), so in the end I canceled the pull request. I can try it again during the next week by creating a new branch directly from `dev` and reintroducing the changes (only `UserSettings.cs` is affected) so it will be clean enough for git, too. Until then, feel free to assign the issue to me.

kerem

2026-03-01 19:06:11 +03:00

closed this issue
added the
🔷Enhancement

⬜ Completed
labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#3040

No description provided.

Rows
Columns