[GH-ISSUE #362] Bug when cancelling the codec selection window when using the system encoder #300

Closed
opened 2026-02-26 09:30:55 +03:00 by kerem · 2 comments
Owner

Originally created by @vletoux on GitHub (Jul 28, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/362

Originally assigned to: @NickeManarin on GitHub.

On a brand new install of Windows 7 with latest patches and the latest version of ScreenToGif, I tried to save a video.
I selected the « system » encoder and it showed a Window to select a codec.
Without any good codec, I pressed cancel and the application crashed immediately.

I see the crash occurs in the Dispose method of the AviWriter class.

This is a non blocking bug but happens quite surprisingly and without recovery possibility.
=> should the exception management being handled at a higher level to avoid an application crash (and the lost of its data) ?

Originally created by @vletoux on GitHub (Jul 28, 2018). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/362 Originally assigned to: @NickeManarin on GitHub. On a brand new install of Windows 7 with latest patches and the latest version of ScreenToGif, I tried to save a video. I selected the « system » encoder and it showed a Window to select a codec. Without any good codec, I pressed cancel and the application crashed immediately. I see the crash occurs in the Dispose method of the AviWriter class. This is a non blocking bug but happens quite surprisingly and without recovery possibility. => should the exception management being handled at a higher level to avoid an application crash (and the lost of its data) ?
kerem 2026-02-26 09:30:55 +03:00
Author
Owner

@NickeManarin commented on GitHub (Jul 28, 2018):

Thanks, I was able to fix this bug and it will be available with the next release (v2.14).
It will still appear as an error after cancelling the encoding, but it wont crash the app.

<!-- gh-comment-id:408606908 --> @NickeManarin commented on GitHub (Jul 28, 2018): Thanks, I was able to fix this bug and it will be available with the next release (v2.14). It will still appear as an error after cancelling the encoding, but it wont crash the app.
Author
Owner

@NickeManarin commented on GitHub (Jul 29, 2018):

and the lost of its data

Btw, if the app closed for you, you can recover your project by clicking on the Recent Projects button.

<!-- gh-comment-id:408650517 --> @NickeManarin commented on GitHub (Jul 29, 2018): > and the lost of its data Btw, if the app closed for you, you can recover your project by clicking on the **Recent Projects** button.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#300
No description provided.