mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-27 08:05:54 +03:00
[GH-ISSUE #1068] FFmpeg importer drops any frames with unchanged pixels into the editor #2982
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#2982
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ParticleCore on GitHub (Feb 3, 2022).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1068
Originally assigned to: @NickeManarin on GitHub.
Describe the bug
When importing an mp4 using the ffmpeg importer any unchanged frames are automatically dropped and there is no option to disable that behavior.
When importing the same video using the mediaplayer importer, all frames are imported correctly, but the frame rate becomes really choppy/not as smooth as when importing with ffmpeg.
Note: I am not referring to when we save the video as a gif, but when we import it into the editor. Right away I can tell there are missing frames when I hit play in the editor.
To Reproduce
Steps to reproduce the behavior:
A good video sample to test this with is a 30s recording of your desktop where nothing at all changes. When importing using the ffmpeg only 1 frame shows in the editor.
Open editor
With the ffmpeg import an mp4 that has at least one period where no pixels change at all
Press play in the editor
The period with no pixels changed is gone
Repeat the same process above but use the mediaplayer importer
The period with no pixels changed is present, but the framerate is really bad
Expected behavior
The importer should not be dropping frames arbitrarily
Desktop (please complete the following information):
Comments
I don't know if the ffmpeg issue is normal and its the editor that is not adding the correct time to the frames that should represent the period where nothing changes in the video, and instead is putting the same short duration for all frames making it look like the unchanged pixels periods are missing. I mention this because that is what makes sense to me, the period with no pixels change at all should be represented by a single frame with a duration of that period.