starred/ScreenToGif
1
0
Fork 0
mirror of https://github.com/NickeManarin/ScreenToGif.git synced 2026-04-25 23:25:52 +03:00
Code Issues 1.1k Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #351] Improper Number Manipulation when Incrementing / Decrementing filenames #290

New issue
Closed
opened 2026-02-26 09:30:52 +03:00 by kerem · 4 comments
kerem commented 2026-02-26 09:30:52 +03:00
Owner
Copy link

Originally created by @NoiSek on GitHub (Jul 3, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/351

When specifying video output options and attempting to increase or decrease the filenumber, the code here will always affect the last number of a filename:

github.com/NickeManarin/ScreenToGif@1a4399a062/ScreenToGif/Windows/Editor.xaml.cs (L4726)

Meaning a filename with an extension specified that includes a number will increment / decrement the extension rather than the filename itself.

As an example, with a filename like filename25.mp3, incrementing five times would produce the following output:

  • file25.mp4
  • file25.mp5
  • file25.mp6
  • file25.mp7
  • file25.mp8
Originally created by @NoiSek on GitHub (Jul 3, 2018). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/351 When specifying video output options and attempting to increase or decrease the filenumber, the code here will always affect the last number of a filename: https://github.com/NickeManarin/ScreenToGif/blob/1a4399a0622ca44213d2ae0b2e18abcd6446ed61/ScreenToGif/Windows/Editor.xaml.cs#L4726 Meaning a filename with an extension specified that includes a number will increment / decrement the extension rather than the filename itself. As an example, with a filename like `filename25.mp3`, incrementing five times would produce the following output: - file25.mp4 - file25.mp5 - file25.mp6 - file25.mp7 - file25.mp8
kerem 2026-02-26 09:30:52 +03:00
kerem commented 2026-02-26 09:30:53 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Jul 3, 2018):

The file extension is not supposed to be typed directly into the filename text box. There's a combo box (selector) to the right. :)

<!-- gh-comment-id:401989361 --> @NickeManarin commented on GitHub (Jul 3, 2018): The file extension is not supposed to be typed directly into the filename text box. There's a combo box (selector) to the right. :)
kerem commented 2026-02-26 09:30:53 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Jul 3, 2018):

Btw, which version are you using? The latest version has a dropdown (with the file formats) very close to the text field where you type the filename.

<!-- gh-comment-id:402321510 --> @NickeManarin commented on GitHub (Jul 3, 2018): Btw, which version are you using? The latest version has a dropdown (with the file formats) very close to the text field where you type the filename.
kerem commented 2026-02-26 09:30:53 +03:00
Author
Owner
Copy link

@NoiSek commented on GitHub (Jul 4, 2018):

I am not using any version of this, I'm just passing along information from the thread that it seems you have already discovered 😄

Figured someone should actually raise the issue on the repo when I saw there was no bug filed.

<!-- gh-comment-id:402324472 --> @NoiSek commented on GitHub (Jul 4, 2018): I am not using any version of this, I'm just passing along information from the thread that it seems you have already discovered 😄 Figured someone should actually raise the issue on the repo when I saw there was no bug filed.
kerem commented 2026-02-26 09:30:53 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Jul 4, 2018):

That user was using an old version of the app, in which the file format dropdown was not very close to the filename.
The current version of the app has a more easy to understand layout. So this is no longer a problem.

<!-- gh-comment-id:402347436 --> @NickeManarin commented on GitHub (Jul 4, 2018): That user was using an old version of the app, in which the file format dropdown was not very close to the filename. The current version of the app has a more easy to understand layout. So this is no longer a problem.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dev
v2.40
2.43.1
2.43
2.42.1
2.42
2.41.5
2.41.4
2.41.3
2.41.2
2.41.1
2.41
2.40.1
2.40
2.39
2.38.1
2.38
2.37.2
2.37.1
2.37
2.36
2.35.4
2.35.3
2.35.2
2.35.1
2.35
2.34.1
2.34
2.33.1
2.33
2.32.1
2.32
2.31
2.30.1
2.30
2.29.1
2.29
2.28.2
2.28.1
2.28
2.27.3
2.27.2
2.27.1
2.27
2.26.1
2.26
2.25
2.24.2
2.24.1
2.24
2.23.2
2.23.1
2.23
2.22.1
2.22
2.21.2
2.21.1
2.21
2.20.4
2.20.3
2.20.2
2.20.1
2.20
2.19.3
2.19.2
2.19.1
2.19
2.18
2.17.1
2.17
2.16
2.15.2
2.15.1
2.15
2.14.1
2.14
2.13.3
2.13.2
2.13.1
2.13
2.12.1
2.12
2.11
2.10
2.9
2.8.1
2.8
2.7.3
2.7.2
2.7.1
2.7
2.6
2.5
2.4
2.3.2
2.3.1
2.3
2.2
2.1
Labels
Clear labels   
copy cats

   
duplicated

   
future feature

   
pull-request

Mirrored from GitHub Pull Request

  
⬜ Accepted

   
⬜ Completed

   
⬜ Help Wanted 💪

   
⬜ In Progress

   
⬜ Missing Details

   
⬜ Pending

   
⬜ Waiting For Answer ⏳

   
🆕 feature preview

   
🔷 Bug 🐛

   
🔷 Out Of Scope

   
🔷 Out Of Scope

   
🔷 Question

   
🔷Enhancement

   
🔷Enhancement

   
🔷Invalid / External

   
🔷Knowledge Base

   
🔷Won't Fix

   
🕑 High

   
🕑 High

   
🕑 High

   
🕕 Medium

   
🕙 Low

   
🕛 Critical
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#290
No description provided.