starred/ScreenToGif
1
0
Fork 0
mirror of https://github.com/NickeManarin/ScreenToGif.git synced 2026-04-26 23:55:57 +03:00
Code Issues 1.1k Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #960] Download Error if an Installer exists #2765

New issue
Open
opened 2026-03-01 19:02:18 +03:00 by kerem · 0 comments
kerem commented 2026-03-01 19:02:18 +03:00
Owner
Copy link

Originally created by @SEWeiTung on GitHub (Aug 1, 2021).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/960

Reproduction:

  1. Change your assembly of your program of ScreenToGif (e.g: change from 2.33.1 to 2.31).
  2. Execute this file first, you will get a tip to update.
  3. Download the installer and upgrade your file to the latest (2.33.1).
  4. Rebuild the project again (redo the step 1).
  5. Redo the step 2.
  6. When to this step, you will find when you click the download button on the download UI, an error happens; however when you cancel it and re-open it, you can download and install again.

Issue Reason:

In DownloadDialog.cs, there's a code with which we execute download logic:
github.com/NickeManarin/ScreenToGif@c8abcbef0b/ScreenToGif/Windows/Other/DownloadDialog.xaml.cs (L209)

It will call the codes, where there's a snippet of codes:
github.com/NickeManarin/ScreenToGif@c8abcbef0b/ScreenToGif/Model/ApplicationViewModel.cs (L1064)

Generally speaking, we don't allow a duplicated installer here (as a minor issue), however, this seems strange for this senario. I tend to have two solutions:

a. Just return true (directly install the existing installer).
b. Remove all the installer there ,no matter whether it gets right or not.

If @NickeManarin is sure this can be fixed (maybe a bug or something else?), please tell me and I'll get a quick fix for you ;)

Originally created by @SEWeiTung on GitHub (Aug 1, 2021). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/960 Reproduction: 1. Change your assembly of your program of ScreenToGif (e.g: change from 2.33.1 to 2.31). 2. Execute this file first, you will get a tip to update. 3. Download the installer and upgrade your file to the latest (2.33.1). 4. Rebuild the project again (redo the step 1). 5. Redo the step 2. 6. When to this step, you will find when you click the download button on the download UI, an error happens; however when you cancel it and re-open it, you can download and install again. Issue Reason: In DownloadDialog.cs, there's a code with which we execute download logic: https://github.com/NickeManarin/ScreenToGif/blob/c8abcbef0b3795faa33686199c640cbb28cacc9c/ScreenToGif/Windows/Other/DownloadDialog.xaml.cs#L209 It will call the codes, where there's a snippet of codes: https://github.com/NickeManarin/ScreenToGif/blob/c8abcbef0b3795faa33686199c640cbb28cacc9c/ScreenToGif/Model/ApplicationViewModel.cs#L1064 Generally speaking, we don't allow a duplicated installer here (as a minor issue), however, this seems strange for this senario. I tend to have two solutions: **a. Just return true (directly install the existing installer). b. Remove all the installer there ,no matter whether it gets right or not.** If @NickeManarin is sure this can be fixed (maybe a bug or something else?), please tell me and I'll get a quick fix for you ;)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dev
v2.40
2.43.1
2.43
2.42.1
2.42
2.41.5
2.41.4
2.41.3
2.41.2
2.41.1
2.41
2.40.1
2.40
2.39
2.38.1
2.38
2.37.2
2.37.1
2.37
2.36
2.35.4
2.35.3
2.35.2
2.35.1
2.35
2.34.1
2.34
2.33.1
2.33
2.32.1
2.32
2.31
2.30.1
2.30
2.29.1
2.29
2.28.2
2.28.1
2.28
2.27.3
2.27.2
2.27.1
2.27
2.26.1
2.26
2.25
2.24.2
2.24.1
2.24
2.23.2
2.23.1
2.23
2.22.1
2.22
2.21.2
2.21.1
2.21
2.20.4
2.20.3
2.20.2
2.20.1
2.20
2.19.3
2.19.2
2.19.1
2.19
2.18
2.17.1
2.17
2.16
2.15.2
2.15.1
2.15
2.14.1
2.14
2.13.3
2.13.2
2.13.1
2.13
2.12.1
2.12
2.11
2.10
2.9
2.8.1
2.8
2.7.3
2.7.2
2.7.1
2.7
2.6
2.5
2.4
2.3.2
2.3.1
2.3
2.2
2.1
Labels
Clear labels   
copy cats

   
duplicated

   
future feature

   
pull-request

Mirrored from GitHub Pull Request

  
⬜ Accepted

   
⬜ Completed

   
⬜ Help Wanted 💪

   
⬜ In Progress

   
⬜ Missing Details

   
⬜ Pending

   
⬜ Waiting For Answer ⏳

   
🆕 feature preview

   
🔷 Bug 🐛

   
🔷 Out Of Scope

   
🔷 Out Of Scope

   
🔷 Question

   
🔷Enhancement

   
🔷Enhancement

   
🔷Invalid / External

   
🔷Knowledge Base

   
🔷Won't Fix

   
🕑 High

   
🕑 High

   
🕑 High

   
🕕 Medium

   
🕙 Low

   
🕛 Critical
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#2765
No description provided.