[GH-ISSUE #881] Playback buttons are disabled after "Save as" #2619

New issue

Closed

opened 2026-03-01 19:00:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 19:00:15 +03:00

Owner

Originally created by @pawlos on GitHub (May 6, 2021).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/881

Originally assigned to: @pawlos on GitHub.

I've noticed a weird behavior of the editor. After saving an animation all of the Replay buttons are disabled (they were enabled before ofc).

Did some checking and the responsible for this is the _applyAction == null in the following code

private void Playback_CanExecute(object sender, CanExecuteRoutedEventArgs e)
{
    e.CanExecute = Project != null && Project.Frames.Count > 1 && !IsLoading && _applyAction == null;
}

as when Save is executed the _applyAction is set to _applyAction = SaveAsButton_Click; in the finally of SaveAsButton_Click . After that apparently it never gets nullified again. I guess this is done to prevent playing the video while saving/encoding is performed (although my simple/quick test with commenting out this line didn't show any issues of playing while saving).

I guess the fix would be to set _applyAction to null when encoding is done, but not sure if that's possible in the current architecture of the system?

Originally created by @pawlos on GitHub (May 6, 2021). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/881 Originally assigned to: @pawlos on GitHub. I've noticed a weird behavior of the editor. After saving an animation all of the Replay buttons are disabled (they were enabled before ofc). Did some checking and the responsible for this is the `_applyAction == null` in the following code private void Playback_CanExecute(object sender, CanExecuteRoutedEventArgs e) { e.CanExecute = Project != null && Project.Frames.Count > 1 && !IsLoading && _applyAction == null; } as when Save is executed the `_applyAction` is set to `_applyAction = SaveAsButton_Click;` in the `finally` of `SaveAsButton_Click` . After that apparently it never gets nullified again. I guess this is done to prevent playing the video while saving/encoding is performed (although my simple/quick test with commenting out this line didn't show any issues of playing while saving). I guess the fix would be to set `_applyAction` to `null` when encoding is done, but not sure if that's possible in the current architecture of the system?

kerem

2026-03-01 19:00:15 +03:00

closed this issue
added the
🔷 Bug 🐛
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#2619

No description provided.

Rows
Columns