mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 15:15:51 +03:00
[GH-ISSUE #302] [Bug] Remove Duplicates resets from 100% to 0.1%. #252
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#252
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Henry00IS on GitHub (Mar 23, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/302
Originally assigned to: @NickeManarin on GitHub.
When I open the remove duplicates panel it will show my last used value (usually 100%). When I click on Apply it will instead quickly turn into 0.1% and mess up my project. So I have to click somewhere on the green text, it will switch to 0.1%, then I enter 100%, and then the value will actually stick and work.
This feature also crashed a couple times in the past, I think this may be the log:
@NickeManarin commented on GitHub (Mar 24, 2018):
Thank you for the feedback.
For the current installed language on your system, what's the decimal separator supposed to be? A dot or a comma? Maybe something else.
@Henry00IS commented on GitHub (Mar 24, 2018):
Just the defaults. A period for English Windows. Like I said actually typing a value in the textbox makes it work, I presume it's probably the bounds check keeping it between 0 and 100 when the focus is lost that is not aware of the value displayed in the textbox unless the user makes an actual edit causing a OnTextChanged event (I didn't see any of the source code though).
@NickeManarin commented on GitHub (Mar 24, 2018):
This one got fixed.
@Henry00IS commented on GitHub (Mar 24, 2018):
Actually it's very buggy for me:
@NickeManarin commented on GitHub (Mar 24, 2018):
Ok, after changing the region format of the numbers I'm able to reproduce this bug.
@NickeManarin commented on GitHub (Mar 24, 2018):
I believe that this one got fixed. I'll run more tests.
A regex was not accepting the input, I replaced with a
double.TryParse()instead.It happened inside the
IsTextAllowed()method.So, with this bug fix, no longer the value will jump from 100.00 to 0.1.
Thank you for your detailed feedback. :)
ScreenToGif 2.13+.zip
@Henry00IS commented on GitHub (Mar 24, 2018):
It works perfectly! Would you like the honor of closing this issue? And thank you so much for the superb real-time solution solving! 😁
@NickeManarin commented on GitHub (Mar 24, 2018):
Awesome! Thank you for spending part of your Saturday helping the project!
@vatterspun commented on GitHub (Apr 12, 2018):
Thanks for appreciating your testers :)