[GH-ISSUE #302] [Bug] Remove Duplicates resets from 100% to 0.1%. #252

Closed
opened 2026-02-26 09:30:44 +03:00 by kerem · 9 comments
Owner

Originally created by @Henry00IS on GitHub (Mar 23, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/302

Originally assigned to: @NickeManarin on GitHub.

When I open the remove duplicates panel it will show my last used value (usually 100%). When I click on Apply it will instead quickly turn into 0.1% and mess up my project. So I have to click somewhere on the green text, it will switch to 0.1%, then I enter 100%, and then the value will actually stick and work.

image

This feature also crashed a couple times in the past, I think this may be the log:

► Title - 
	Current Domain Unhandled Exception - Unknown
▬ Message - 
	Sequence contains no elements
○ Type - 
	System.InvalidOperationException
♦ [Version] Date/Hour - 
	[2.12.1] 03/14/2018 07:54:14
▲ Source - 
	mscorlib
▼ TargetSite - 
	System.Runtime.Remoting.Messaging.IMessage EndInvokeHelper(System.Runtime.Remoting.Messaging.Message, Boolean)
♠ StackTrace - 

Server stack trace: 
   at System.Linq.Enumerable.Min(IEnumerable`1 source)
   at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]& outArgs)
   at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(IMessage msg, IMessageSink replySink)

Exception rethrown at [0]: 
   at System.Runtime.Remoting.Proxies.RealProxy.EndInvokeHelper(Message reqMsg, Boolean bProxyCase)
   at System.Runtime.Remoting.Proxies.RemotingProxy.Invoke(Object NotUsed, MessageData& msgData)
   at ScreenToGif.Windows.Editor.RemoveDuplicates.EndInvoke(IAsyncResult result)
   at ScreenToGif.Windows.Editor.RemoveDuplicatesCallback(IAsyncResult ar)
   at System.Runtime.Remoting.Messaging.AsyncResult.SyncProcessMessage(IMessage msg)
   at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(IMessage msg, IMessageSink replySink)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
Originally created by @Henry00IS on GitHub (Mar 23, 2018). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/302 Originally assigned to: @NickeManarin on GitHub. When I open the remove duplicates panel it will show my last used value (usually 100%). When I click on **Apply** it will instead quickly turn into 0.1% and mess up my project. So I have to click somewhere on the green text, it will switch to 0.1%, then I enter 100%, and then the value will actually stick and work. ![image](https://user-images.githubusercontent.com/7905726/37821126-080bc496-2e83-11e8-9f05-63aad88a03a4.png) This feature also crashed a couple times in the past, I think this may be the log: ``` ► Title - Current Domain Unhandled Exception - Unknown ▬ Message - Sequence contains no elements ○ Type - System.InvalidOperationException ♦ [Version] Date/Hour - [2.12.1] 03/14/2018 07:54:14 ▲ Source - mscorlib ▼ TargetSite - System.Runtime.Remoting.Messaging.IMessage EndInvokeHelper(System.Runtime.Remoting.Messaging.Message, Boolean) ♠ StackTrace - Server stack trace: at System.Linq.Enumerable.Min(IEnumerable`1 source) at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]& outArgs) at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(IMessage msg, IMessageSink replySink) Exception rethrown at [0]: at System.Runtime.Remoting.Proxies.RealProxy.EndInvokeHelper(Message reqMsg, Boolean bProxyCase) at System.Runtime.Remoting.Proxies.RemotingProxy.Invoke(Object NotUsed, MessageData& msgData) at ScreenToGif.Windows.Editor.RemoveDuplicates.EndInvoke(IAsyncResult result) at ScreenToGif.Windows.Editor.RemoveDuplicatesCallback(IAsyncResult ar) at System.Runtime.Remoting.Messaging.AsyncResult.SyncProcessMessage(IMessage msg) at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(IMessage msg, IMessageSink replySink) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem() at System.Threading.ThreadPoolWorkQueue.Dispatch() ```
kerem 2026-02-26 09:30:44 +03:00
Author
Owner

@NickeManarin commented on GitHub (Mar 24, 2018):

Thank you for the feedback.

For the current installed language on your system, what's the decimal separator supposed to be? A dot or a comma? Maybe something else.

<!-- gh-comment-id:375891034 --> @NickeManarin commented on GitHub (Mar 24, 2018): Thank you for the feedback. For the current installed language on your system, what's the decimal separator supposed to be? A dot or a comma? Maybe something else.
Author
Owner

@Henry00IS commented on GitHub (Mar 24, 2018):

Just the defaults. A period for English Windows. Like I said actually typing a value in the textbox makes it work, I presume it's probably the bounds check keeping it between 0 and 100 when the focus is lost that is not aware of the value displayed in the textbox unless the user makes an actual edit causing a OnTextChanged event (I didn't see any of the source code though).

image

<!-- gh-comment-id:375891475 --> @Henry00IS commented on GitHub (Mar 24, 2018): Just the defaults. A period for English Windows. Like I said actually typing a value in the textbox makes it work, I presume it's probably the bounds check keeping it between 0 and 100 when the focus is lost that is not aware of the value displayed in the textbox unless the user makes an actual edit causing a OnTextChanged event (I didn't see any of the source code though). ![image](https://user-images.githubusercontent.com/7905726/37864791-913b0fe2-2f73-11e8-98a4-e43054d7da07.png)
Author
Owner

@NickeManarin commented on GitHub (Mar 24, 2018):

This feature also crashed a couple times in the past, I think this may be the log:

This one got fixed.

<!-- gh-comment-id:375891492 --> @NickeManarin commented on GitHub (Mar 24, 2018): > This feature also crashed a couple times in the past, I think this may be the log: This one got fixed.
Author
Owner

@Henry00IS commented on GitHub (Mar 24, 2018):

Actually it's very buggy for me:

buggy

<!-- gh-comment-id:375892129 --> @Henry00IS commented on GitHub (Mar 24, 2018): Actually it's very buggy for me: ![buggy](https://user-images.githubusercontent.com/7905726/37864926-6a9eb5bc-2f75-11e8-9c1e-932acaf1d814.gif)
Author
Owner

@NickeManarin commented on GitHub (Mar 24, 2018):

Ok, after changing the region format of the numbers I'm able to reproduce this bug.

<!-- gh-comment-id:375892444 --> @NickeManarin commented on GitHub (Mar 24, 2018): Ok, after changing the region format of the numbers I'm able to reproduce this bug.
Author
Owner

@NickeManarin commented on GitHub (Mar 24, 2018):

Actually it's very buggy for me:

I believe that this one got fixed. I'll run more tests.
A regex was not accepting the input, I replaced with a double.TryParse() instead.
It happened inside the IsTextAllowed() method.

So, with this bug fix, no longer the value will jump from 100.00 to 0.1.

Thank you for your detailed feedback. :)

ScreenToGif 2.13+.zip

<!-- gh-comment-id:375894094 --> @NickeManarin commented on GitHub (Mar 24, 2018): > Actually it's very buggy for me: I believe that this one got fixed. I'll run more tests. A regex was not accepting the input, I replaced with a `double.TryParse()` instead. It happened inside the `IsTextAllowed()` method. So, with this bug fix, no longer the value will jump from 100.00 to 0.1. Thank you for your detailed feedback. :) [ScreenToGif 2.13+.zip](https://github.com/NickeManarin/ScreenToGif/files/1844486/ScreenToGif.2.13.zip)
Author
Owner

@Henry00IS commented on GitHub (Mar 24, 2018):

It works perfectly! Would you like the honor of closing this issue? And thank you so much for the superb real-time solution solving! 😁

<!-- gh-comment-id:375894269 --> @Henry00IS commented on GitHub (Mar 24, 2018): It works perfectly! Would you like the honor of closing this issue? And **thank you so much** for the superb real-time solution solving! 😁
Author
Owner

@NickeManarin commented on GitHub (Mar 24, 2018):

Awesome! Thank you for spending part of your Saturday helping the project!

<!-- gh-comment-id:375894404 --> @NickeManarin commented on GitHub (Mar 24, 2018): Awesome! Thank you for spending part of your Saturday helping the project!
Author
Owner

@vatterspun commented on GitHub (Apr 12, 2018):

Awesome! Thank you for spending part of your Saturday helping the project!

Thanks for appreciating your testers :)

<!-- gh-comment-id:380666316 --> @vatterspun commented on GitHub (Apr 12, 2018): > Awesome! Thank you for spending part of your Saturday helping the project! Thanks for appreciating your testers :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#252
No description provided.