mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-26 07:35:54 +03:00
[GH-ISSUE #288] For auto language #239
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#239
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @laiqun on GitHub (Mar 15, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/288
could you use
"System.Threading.Thread.CurrentThread.CurrentCulture.Name"
instead of "CultureInfo.InstalledUICulture" for auto language detection?
@laiqun commented on GitHub (Mar 15, 2018):
The different between those ,already be discussed in this url:
https://stackoverflow.com/questions/329033/what-is-the-difference-between-currentculture-and-currentuiculture-properties-of
@spietras commented on GitHub (Mar 23, 2018):
If you mean what is happening in LocalizationHelper.cs after clicking on Autodetected language in Language options, then we need to use CultureInfo.InstalledUICulture, because it's the only one that always provides specific cultures (such as pt-BR as opposed to just pt). We have defined our own language codes management, so sometimes specifics are needed, sometimes neutrals. But we always should start from specifics. When we have a specific culture and there is a resource file for that culture, then we are good to go. If there is no resource file for that culture, we can check for parent culture (which is always neutral culture, for example, pt is the parent of pt-BR) and check if we have a resource file for that. Again, if we have that's great, but otherwise (which means that language is unsupported) we switch to the English language, which is always present and ready to use.