starred/ScreenToGif
1
0
Fork 0
mirror of https://github.com/NickeManarin/ScreenToGif.git synced 2026-04-25 23:25:52 +03:00
Code Issues 1.1k Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #287] Import a GifFile without normal file ending #237

New issue
Closed
opened 2026-02-26 09:30:40 +03:00 by kerem · 3 comments
kerem commented 2026-02-26 09:30:40 +03:00
Owner
Copy link

Originally created by @EndlessMISAKA on GitHub (Mar 13, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/287

Originally assigned to: @NickeManarin on GitHub.

When a GifFile is not end with a GIF Trailer, that the Program will getting into a no-end loading.
Since we used the same Decoder, so I used the bad giffile to tested, and found this bug.
In my program this bug will throw a exception, so I changed the code to ignore the exception.

Maybe you will has a question that why should I need to fixed this bug?
Because this bad giffile can open by Windows Photo like a normal giffile.

bad

Best Wishes to you.This is a wonderful program.
(Sorry,I don't good at English.)

Originally created by @EndlessMISAKA on GitHub (Mar 13, 2018). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/287 Originally assigned to: @NickeManarin on GitHub. When a GifFile is not end with a GIF Trailer, that the Program will getting into a no-end loading. Since we used the same Decoder, so I used the bad giffile to tested, and found this bug. In my program this bug will throw a exception, so I changed the code to ignore the exception. Maybe you will has a question that why should I need to fixed this bug? Because this bad giffile can open by Windows Photo like a normal giffile. ![bad](https://user-images.githubusercontent.com/25360394/37323444-d8bffdcc-26be-11e8-90d8-460cbb3296a3.gif) Best Wishes to you.This is a wonderful program. (Sorry,I don't good at English.)
kerem 2026-02-26 09:30:40 +03:00
kerem commented 2026-02-26 09:30:41 +03:00
Author
Owner
Copy link

@vatterspun commented on GitHub (Mar 16, 2018):

I'm not sure I understand what you're having issues with.

(Sorry,I don't good at English.)

Could you describe what you saw? Could you then describe what went wrong? What were you expecting to see?

<!-- gh-comment-id:373567120 --> @vatterspun commented on GitHub (Mar 16, 2018): I'm not sure I understand what you're having issues with. > (Sorry,I don't good at English.) Could you describe what you saw? Could you then describe what went wrong? What were you expecting to see?
kerem commented 2026-02-26 09:30:41 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Mar 16, 2018):

@vatterspun The app stays in an infinite loading process when a corrupted gif file is imported. So, @EndlessMISAKA wants the app to be able to load all possible frames, without staying in an infinite loading.

<!-- gh-comment-id:373579081 --> @NickeManarin commented on GitHub (Mar 16, 2018): @vatterspun The app stays in an infinite loading process when a corrupted gif file is imported. So, @EndlessMISAKA wants the app to be able to load all possible frames, without staying in an infinite loading.
kerem commented 2026-02-26 09:30:41 +03:00
Author
Owner
Copy link

@NickeManarin commented on GitHub (Mar 16, 2018):

Done. With v2.13, it will load all frames until it can read anymore.

image

<!-- gh-comment-id:373580994 --> @NickeManarin commented on GitHub (Mar 16, 2018): Done. With v2.13, it will load all frames until it can read anymore. ![image](https://user-images.githubusercontent.com/14798947/37499966-80019c34-28a5-11e8-855f-293ddfd55172.png)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dev
v2.40
2.43.1
2.43
2.42.1
2.42
2.41.5
2.41.4
2.41.3
2.41.2
2.41.1
2.41
2.40.1
2.40
2.39
2.38.1
2.38
2.37.2
2.37.1
2.37
2.36
2.35.4
2.35.3
2.35.2
2.35.1
2.35
2.34.1
2.34
2.33.1
2.33
2.32.1
2.32
2.31
2.30.1
2.30
2.29.1
2.29
2.28.2
2.28.1
2.28
2.27.3
2.27.2
2.27.1
2.27
2.26.1
2.26
2.25
2.24.2
2.24.1
2.24
2.23.2
2.23.1
2.23
2.22.1
2.22
2.21.2
2.21.1
2.21
2.20.4
2.20.3
2.20.2
2.20.1
2.20
2.19.3
2.19.2
2.19.1
2.19
2.18
2.17.1
2.17
2.16
2.15.2
2.15.1
2.15
2.14.1
2.14
2.13.3
2.13.2
2.13.1
2.13
2.12.1
2.12
2.11
2.10
2.9
2.8.1
2.8
2.7.3
2.7.2
2.7.1
2.7
2.6
2.5
2.4
2.3.2
2.3.1
2.3
2.2
2.1
Labels
Clear labels   
copy cats

   
duplicated

   
future feature

   
pull-request

Mirrored from GitHub Pull Request

  
⬜ Accepted

   
⬜ Completed

   
⬜ Help Wanted 💪

   
⬜ In Progress

   
⬜ Missing Details

   
⬜ Pending

   
⬜ Waiting For Answer ⏳

   
🆕 feature preview

   
🔷 Bug 🐛

   
🔷 Out Of Scope

   
🔷 Out Of Scope

   
🔷 Question

   
🔷Enhancement

   
🔷Enhancement

   
🔷Invalid / External

   
🔷Knowledge Base

   
🔷Won't Fix

   
🕑 High

   
🕑 High

   
🕑 High

   
🕕 Medium

   
🕙 Low

   
🕛 Critical
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#237
No description provided.